mirror of
https://we.phorge.it/source/phorge.git
synced 2025-02-08 21:08:29 +01:00
d8d65f3f87
Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. ``` EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261] arcanist(head=master, ref.master=b325304b6e52), phorge(head=uiExamples, ref.master=dd24c94b0741, ref.uiExamples=dd24c94b0741) #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/view/phui/PHUISegmentBarSegmentView.php:58] ``` Closes T15441 Test Plan: After applying this change, going to `/uiexample/view/PhabricatorAphrontBarUIExample/`,"Bars (PhabricatorAphrontBarUIExample)" renders with beautiful colors. To see that page, enable prototypes with: ./bin/config set phabricator.show-prototypes true Also try to create a Milestone on a Project, with the Config `maniphest.points` enabled, and try to create some Tasks with different points. Visit its Workboard to see the bar that still works with a useful tooltip. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15441 Differential Revision: https://we.phorge.it/D25272 |
||
|---|---|---|
| .. | ||
| __tests__ | ||
| calendar | ||
| PHUI.php | ||
| PHUIActionPanelView.php | ||
| PHUIBadgeBoxView.php | ||
| PHUIBadgeMiniView.php | ||
| PHUIBadgeView.php | ||
| PHUIBigInfoView.php | ||
| PHUIBoxView.php | ||
| PHUIButtonBarView.php | ||
| PHUIButtonView.php | ||
| PHUICMSView.php | ||
| PHUIColor.php | ||
| PHUICrumbsView.php | ||
| PHUICrumbView.php | ||
| PHUICurtainObjectRefListView.php | ||
| PHUICurtainObjectRefView.php | ||
| PHUIDocumentSummaryView.php | ||
| PHUIDocumentView.php | ||
| PHUIFeedStoryView.php | ||
| PHUIHeaderView.php | ||
| PHUIHeadThingView.php | ||
| PHUIHovercardView.php | ||
| PHUIIconCircleView.php | ||
| PHUIIconView.php | ||
| PHUIImageMaskView.php | ||
| PHUIInfoView.php | ||
| PHUIInvisibleCharacterView.php | ||
| PHUILauncherView.php | ||
| PHUILeftRightView.php | ||
| PHUILinkView.php | ||
| PHUIListItemView.php | ||
| PHUIListView.php | ||
| PHUIObjectBoxView.php | ||
| PHUIObjectItemListView.php | ||
| PHUIObjectItemView.php | ||
| PHUIPagerView.php | ||
| PHUIPinboardItemView.php | ||
| PHUIPinboardView.php | ||
| PHUIPropertyGroupView.php | ||
| PHUIPropertyListView.php | ||
| PHUIRemarkupPreviewPanel.php | ||
| PHUISegmentBarSegmentView.php | ||
| PHUISegmentBarView.php | ||
| PHUIStatusItemView.php | ||
| PHUIStatusListView.php | ||
| PHUITabGroupView.php | ||
| PHUITabView.php | ||
| PHUITagView.php | ||
| PHUITimelineEventView.php | ||
| PHUITimelineView.php | ||
| PHUITwoColumnView.php | ||
| PHUIWorkboardView.php | ||
| PHUIWorkpanelView.php | ||