Bob Trahan b14ca38940 Conpherence - improve stack re: non-update updates ... Summary: Fixes T7761. Fixes T7318. When we send an empty message to the server, pretend its just a request to load the page. Make load a bit smarter such that if we don't get back any transactions, rather than error like the fool, just send down to the client the notion of a 'non_update'. Instrument the client to just turn off the appropriate loading state, etc for a non update. T7318 is a tricky beast since we don't know exactly how to reproduce it but if / when it occurs again it would be some other bizarre application behavior maybe? We won't be getting the execption anymore, that's for sure. Test Plan: removed code in `ConpherenceThreadManager.sendMessage` that protects against sending empty messages. sent empty messages (non updates) like whoa and everything worked on both durable column and main column view. re-added the code in `ConpherenceThreadManager.sendMessage` and noted empty messages did not send while any text including a space sent up nicely Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7318, T7761 Differential Revision: https://secure.phabricator.com/D12339		2015-04-09 15:07:12 -07:00
..
almanac	Allow applications to have multiple "help" menu items	2015-04-01 11:51:48 -07:00
aphlict/management	Create the Aphlict PID directory	2015-02-28 21:53:10 +11:00
arcanist/conduit	Fix a method call in arcanist.projectinfo	2015-02-02 14:38:40 -08:00
audit	Allow "send me an email" in personal rules to punch through settings	2015-04-06 10:01:32 -07:00
auth	Fix some odd looking arrays	2015-04-05 22:29:39 +10:00
base	Fix some odd looking arrays	2015-04-05 22:29:39 +10:00
cache	Cache - fix method call typo	2015-04-08 18:01:58 -07:00
calendar	Move handle fetching into tokenizer Datasources	2015-03-31 14:10:32 -07:00
celerity	Add support for playing sounds	2015-03-10 14:20:00 -07:00
chatlog	Mark ChatLog as deprecated	2015-04-07 07:24:02 +10:00
conduit	Re-enable the deprecated calls setup check	2015-04-07 18:08:49 +10:00
config	Emit cache setup issues from cache specs	2015-04-08 11:31:01 -07:00
conpherence	Conpherence - improve stack re: non-update updates	2015-04-09 15:07:12 -07:00
console	Revert "Minor change to suppress linter warning"	2015-04-07 09:05:31 +10:00
countdown	Convert all tokenizers to take token/scalar inputs	2015-03-31 14:10:55 -07:00
daemon	Examine fewer daemons for variant config	2015-03-15 11:31:07 -07:00
dashboard	Remove Controller->getHandle() and Controller->loadHandles()	2015-03-31 05:48:20 -07:00
differential	Allow "send me an email" in personal rules to punch through settings	2015-04-06 10:01:32 -07:00
diffusion	Send Markdown in Diffusion through SourceSans	2015-04-08 09:41:56 -07:00
diviner	Add doclink for Diviner documentation	2015-04-07 07:23:50 +10:00
doorkeeper	Add "phabricator.silent" for stopping all outbound events from an install	2015-03-18 07:09:43 -07:00
draft/storage	Fix visiblity of LiskDAO::getConfiguration()	2015-01-14 06:54:13 +11:00
drydock	Allow applications to have multiple "help" menu items	2015-04-01 11:51:48 -07:00
fact	Modernize Fact a bit	2015-03-03 13:48:30 -08:00
feed	Convert all tokenizers to take token/scalar inputs	2015-03-31 14:10:55 -07:00
files	Fix some odd looking arrays	2015-04-05 22:29:39 +10:00
flag	Make pink flags pink	2015-03-17 18:29:07 -07:00
fund	Subclass most ReplyHandlers from TransactionReplyHandler	2015-04-01 08:39:50 -07:00
harbormaster	Convert all tokenizers to take token/scalar inputs	2015-03-31 14:10:55 -07:00
help	Allow applications to have multiple "help" menu items	2015-04-01 11:51:48 -07:00
herald	Fix issue with transcripts that do not have associated rules	2015-04-06 10:08:33 -07:00
home	Allow applications to have multiple "help" menu items	2015-04-01 11:51:48 -07:00
legalpad	Expose all application mail receivers	2015-04-01 11:52:02 -07:00
lipsum	Minor tidying of lipsum generate workflow	2015-03-01 09:41:52 +11:00
macro	Expose all application mail receivers	2015-04-01 11:52:02 -07:00
mailinglists	Improve granluarity and defaults of security.allow-outbound-http	2015-03-23 10:44:03 -07:00
maniphest	Fix "To: Unknown Object" on outbound Maniphest mail with no owner	2015-04-08 05:22:16 -07:00
meta	Provide better general high-level documentation on mail commands	2015-04-01 11:51:49 -07:00
metamta	Allow "send me an email" in personal rules to punch through settings	2015-04-06 10:01:32 -07:00
notification	Move PHUIErrorView to PHUIInfoView	2015-03-01 14:45:56 -08:00
nuance	Remove getIconName from all applications	2015-01-30 12:11:21 -08:00
oauthserver	Allow applications to have multiple "help" menu items	2015-04-01 11:51:48 -07:00
owners	Allow applications to have multiple "help" menu items	2015-04-01 11:51:48 -07:00
passphrase	Remove most callsites to Controller->renderHandlesForPHIDs()	2015-03-31 05:48:19 -07:00
paste	Fix some odd looking arrays	2015-04-05 22:29:39 +10:00
people	Convert all tokenizers to take token/scalar inputs	2015-03-31 14:10:55 -07:00
phame	Allow applications to have multiple "help" menu items	2015-04-01 11:51:48 -07:00
phid	Remove implode_selected_handle_links()	2015-03-31 05:48:20 -07:00
phlux	Remove getIconName from all applications	2015-01-30 12:11:21 -08:00
pholio	Expose all application mail receivers	2015-04-01 11:52:02 -07:00
phortune	Make taller tables the default for AphrontTableView	2015-04-08 08:38:15 -07:00
phpast	Use PhutilXHPASTBinary methods	2015-02-03 06:59:16 +11:00
phragment	Remove most callsites to Controller->renderHandlesForPHIDs()	2015-03-31 05:48:19 -07:00
phrequent	Convert all tokenizers to take token/scalar inputs	2015-03-31 14:10:55 -07:00
phriction	Allow "send me an email" in personal rules to punch through settings	2015-04-06 10:01:32 -07:00
policy	Fix some odd looking arrays	2015-04-05 22:29:39 +10:00
ponder	Expose all application mail receivers	2015-04-01 11:52:02 -07:00
project	Tune project hashtags a little more	2015-04-03 16:38:19 -07:00
releeph	Expose all application mail receivers	2015-04-01 11:52:02 -07:00
remarkup/conduit	Rename Conduit classes	2014-07-25 10:54:15 +10:00
repository	Enforce that global locks have keys shorter than 64 characters	2015-04-02 13:42:22 -07:00
search	Convert all tokenizers to take token/scalar inputs	2015-03-31 14:10:55 -07:00
settings	Remove monospaced font preference global defaults	2015-04-06 08:08:53 -07:00
slowvote	Allow applications to have multiple "help" menu items	2015-04-01 11:51:48 -07:00
subscriptions	Implement a "!subscribe" mail command	2015-04-01 11:51:52 -07:00
support/application	Implement the getName method in PhabricatorApplication subclasses	2014-07-23 23:52:50 +10:00
system	Fix visibility of PhutilArgumentWorkflow::didConstruct methods	2015-01-16 07:42:07 +11:00
tokens	Remove getIconName from all applications	2015-01-30 12:11:21 -08:00
transactions	Fix bad rendering for custom policy descriptions	2015-04-09 13:10:19 -07:00
typeahead	Typeahead - filter typeaheads that the viewer can't see in typeahead debug tool	2015-04-06 15:24:58 -07:00
uiexample	Add ability to have tooltips on buttons	2015-03-26 11:09:20 -07:00
xhprof	Set device true on all XHProf pages	2015-03-05 08:45:51 -08:00