revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley b219285999 Fix handling of implicit comment transaction in paste creation 
Summary:
Fixes T9850. The `getComment()` test should be a `hasComment()` test, in order to discard empty comments.

Also backport a couple of future fixes which can get you into trouble if you reconfigure forms in awkward ways.

Test Plan: Created a new paste without a comment.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9850

Differential Revision: https://secure.phabricator.com/D14571
2015-11-25 08:25:10 -08:00
..
almanac Allow device bindings to be destroyed 2015-11-16 07:14:55 +11:00
aphlict Update "should not run as root" message 2015-10-31 11:20:23 +00:00
arcanist/conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
audit Render Remarkup in emails 2015-11-24 06:43:01 +11:00
auth JIRA Integration: Link and/or Comment 2015-11-12 19:30:43 +00:00
badges Render Remarkup in emails 2015-11-24 06:43:01 +11:00
base Allow form configurations to retitle and reorder forms and add preambles 2015-11-22 15:12:57 -08:00
cache Make disk-based setup caches more correct (but slower) 2015-10-19 11:14:46 -07:00
calendar Starting the Calendar user guide 2015-11-07 07:50:47 -08:00
celerity Add mask-icon for Safari pinned tab 2015-11-22 13:04:06 -08:00
chatlog Update Chatlog for handleRequest 2015-07-31 09:14:44 -07:00
conduit Have EditEngine API methods provide the correct application to Conduit 2015-11-16 10:02:50 -08:00
config Remarkup links to link to short url instead of long and fix commenting on Phurl's 2015-11-17 11:02:13 -08:00
conpherence Extract PHIDs from transactions later, fixing Paste extraction/attachment 2015-11-17 08:37:07 -08:00
console Push construction of routing maps into Sites 2015-08-31 04:01:01 -07:00
countdown Render Remarkup in emails 2015-11-24 06:43:01 +11:00
daemon Remove daemon envHash and envInfo 2015-11-11 08:54:45 +11:00
dashboard Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
differential Render Remarkup in emails 2015-11-24 06:43:01 +11:00
diffusion Fix history link in Diffusion non-root browse views 2015-11-16 09:00:29 -08:00
diviner Various translation improvements 2015-11-03 07:02:46 +11:00
doorkeeper JIRA Integration: Link and/or Comment 2015-11-12 19:30:43 +00:00
draft/storage Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
drydock Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
fact Update Facts for handleRequest 2015-07-27 09:12:35 -07:00
feed Remove some low-hanging buildStandardPageResponse() methods 2015-11-03 10:11:36 -08:00
files Increase the maximum size eligible for image transforms configurable from 4MB->16MB 2015-11-25 06:42:44 -08:00
flag Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
fund Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
harbormaster Add objectPHID keys to Harbormaster task schedulers 2015-11-23 05:58:54 -08:00
help Remove some low-hanging buildStandardPageResponse() methods 2015-11-03 10:11:36 -08:00
herald Make Herald rules subscribable 2015-11-17 06:27:13 +11:00
home Remove some low-hanging buildStandardPageResponse() methods 2015-11-03 10:11:36 -08:00
legalpad Use new DocumentView for Legalpad previews 2015-11-24 10:07:39 -08:00
lipsum Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
macro Allow any {icon} to spin 2015-10-30 16:02:19 +00:00
maniphest Render Remarkup in emails 2015-11-24 06:43:01 +11:00
meta PHUIDocumentViewPro tweaks 2015-11-03 13:43:26 -08:00
metamta Fix a potentially lax hash comparison 2015-11-10 10:22:25 -08:00
multimeter Various translation improvements 2015-11-03 07:02:46 +11:00
notification Remove some low-hanging buildStandardPageResponse() methods 2015-11-03 10:11:36 -08:00
nuance Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
oauthserver Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
owners Fix file PHID extraction in Owners and Differential 2015-11-17 08:36:50 -08:00
passphrase Introduce PHUIRemarkupView, a sane way to work with Remarkup 2015-10-15 10:20:19 -07:00
paste Have EditEngine API methods provide the correct application to Conduit 2015-11-16 10:02:50 -08:00
people Move some files around 2015-11-17 06:26:13 +11:00
phame Use PHUIRemarkupPreviewView in Phame 2015-11-23 10:36:02 -08:00
phid Provide formal Users/Projects/Mailable fields for EditEngine 2015-11-04 12:05:41 -08:00
phlux Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
pholio Extract PHIDs from transactions later, fixing Paste extraction/attachment 2015-11-17 08:37:07 -08:00
phortune Remove the PhortuneNotImplementedException class 2015-11-12 06:33:39 +11:00
phpast Rename XHPAST database 2015-11-14 21:41:28 +11:00
phragment Various translation improvements 2015-11-03 07:02:46 +11:00
phrequent [Redesign] PhabricatorApplicationSearchResultView 2015-06-19 11:46:20 +01:00
phriction Render Remarkup in emails 2015-11-24 06:43:01 +11:00
phurl Render Remarkup in emails 2015-11-24 06:43:01 +11:00
policy Move some files around 2015-11-17 06:26:13 +11:00
ponder Fix edits of Ponder comments which mention other objects 2015-11-22 15:12:28 -08:00
project Markup project hashtags which begin with (or contain only) digits 2015-11-23 06:50:43 -08:00
releeph Render Remarkup in emails 2015-11-24 06:43:01 +11:00
remarkup/conduit phtize all the things 2015-05-22 21:16:39 +10:00
repository add "update" mode to Diffusion coverage Conduit 2015-11-09 16:52:34 -08:00
search Remove some low-hanging buildStandardPageResponse() methods 2015-11-03 10:11:36 -08:00
settings Remove Certificate page 2015-11-04 06:35:22 +00:00
slowvote Render Remarkup in emails 2015-11-24 06:43:01 +11:00
spaces Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
subscriptions Various translation improvements 2015-11-03 07:02:46 +11:00
support/application Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
system Permanently destroy Almanac properties with the destruction engine 2015-11-15 20:58:50 +00:00
tokens Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
transactions Fix handling of implicit comment transaction in paste creation 2015-11-25 08:25:10 -08:00
typeahead Use unicode mode when tokenizing strings like user realnames 2015-11-08 07:03:09 -08:00
uiexample More ActionPanel colors, hardening 2015-09-16 09:22:31 -07:00
xhprof Update XHProf for handleRequest 2015-08-01 15:41:57 -07:00