Andre Klapper 43539b220c Remove trivial cases of unreachable code ... Summary: Static code analysis can detect `Unreachable statement - code above always terminates.` The vast majority of occurrences in the Phorge codebase are due to an unreachable `break` within a `case` after a `return` or after an all-covering `if/else`. All this noise makes it harder to spot real logic issues (there are some!), thus fix these trivial cases. Test Plan: Examine the code; run static code analysis. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25802		2024-09-04 12:17:28 +02:00
..
application	Remove product literal strings in "pht()", part 2	2022-04-25 12:22:26 -07:00
check	Fix PHP 8.1 "strlen(null)" exception checking for open setup issues in PhabricatorSetupCheck	2024-05-10 18:16:12 +02:00
constants	Config re-design	2017-09-05 15:24:15 -07:00
controller	Remove unused parameter from PhabricatorConfigConsoleController::newLibraryVersionTable() call	2024-07-26 10:24:26 +02:00
custom	Add missing variable names to PHPDoc @param of methods	2024-08-21 15:06:26 +02:00
editor	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
engine	When we "discover" new fatal setup issues, stop serving traffic	2016-11-21 15:54:40 -08:00
exception	Apply some autofix linter rules	2014-09-10 06:55:05 +10:00
issue	Add missing variable names to PHPDoc @param of methods	2024-08-21 15:06:26 +02:00
json	Add missing variable names to PHPDoc @param of methods	2024-08-21 15:06:26 +02:00
management	Allow bin/config to create config file	2019-09-08 00:16:19 +00:00
module	Split setup checks into "preflight" and "normal" checks	2016-09-06 11:57:18 -07:00
option	Add missing variable names to PHPDoc @param of methods	2024-08-21 15:06:26 +02:00
phid	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
query	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
response	Remove product literal strings in "pht()", part 4	2022-04-25 12:22:27 -07:00
schema	Update MySQL schema inspection code for deprecation of integer display widths	2020-05-18 12:10:31 -07:00
storage	Remove trivial cases of unreachable code	2024-09-04 12:17:28 +02:00
type	Simplify one "array_keys/range" -> "phutil_is_natural_list()" in "phabricator/"	2019-02-28 07:29:36 -08:00
view	Improve command line prompts in setup issue pages	2023-12-07 16:22:24 +00:00