revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-03-13 04:44:53 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
Andre Klapper b4bc480817 Fix PHP 8.1 "strlen(null)" exceptions creating an OAuth provider 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/provider/PhabricatorOAuth1AuthProvider.php:163]
```

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/provider/PhabricatorOAuth1AuthProvider.php:178]
```

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/provider/PhabricatorOAuthAuthProvider.php:147]
```

Closes T15912

Test Plan: As an admin, create an OAuth provider (such as using Bitbucket) and check the error logs or Dark Console.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15912

Differential Revision: https://we.phorge.it/D25771
2024-09-05 12:28:22 +02:00
..
almanac Drydock and Almanac: add welcome pages 2024-06-25 09:37:01 +02:00
aphlict Fix PHP 8.1 "strlen(null)" exception for "/bin/aphlict notify" without parameter 2024-04-17 13:11:07 +02:00
arcanist/conduit
audit Allow to uninstall (hide) Audit application 2024-02-12 12:10:06 +01:00
auth Fix PHP 8.1 "strlen(null)" exceptions creating an OAuth provider 2024-09-05 12:28:22 +02:00
badges Disallow awarding a badge without selecting recipient 2024-07-30 10:50:28 +02:00
base Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
cache Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
calendar Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
celerity Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
conduit Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
config Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
conpherence Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
console log deprecation events in Dark Console 2023-08-31 08:18:28 -07:00
countdown Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
daemon Remove unused parameter from PhabricatorDaemonController::buildSideNavView() call 2024-07-26 13:48:44 +02:00
dashboard Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
differential Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
diffusion Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
diviner Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
doorkeeper Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
draft/storage Save drafts for inline comments currently being edited 2020-05-04 13:19:42 -07:00
drydock Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
fact Suppress PHP 8.1 warnings "Return type mixed is not covariant with tentative return type mixed of method Iterator::key()" 2024-08-02 11:44:25 +02:00
favorites Make "Favorites" work more like other customizable menus 2019-04-09 13:59:35 -07:00
feed Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
files Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
flag Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
fund Deprecate Fund and Phortune prototype applications 2024-02-06 09:16:19 +01:00
guides Remove product literal strings in "pht()", part 5 2022-04-25 12:22:27 -07:00
harbormaster Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
help Tokenize external editor links so they can be safely materialized on the client 2020-04-19 09:02:49 -07:00
herald Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
home Fix PHP 8.1 "strlen(null)" exception which blocks rendering the Home page 2023-05-01 15:37:56 +02:00
legalpad Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
lipsum Add "--force" and "--quickly" flags to bin/lipsum 2017-02-27 09:09:41 -08:00
macro Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
maniphest Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
meta Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
metamta Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
multimeter Fix PHP 8.1 "explode(null)" exception which blocks rendering the Multimeter page 2023-05-29 12:35:54 +02:00
notification Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
nuance Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
oauthserver Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
owners Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
packages Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
passphrase Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
paste Fix PHP 8.1 "strlen(null)" exception in PhabricatorPasteLanguageTransaction.php 2024-05-02 10:28:08 +02:00
people Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
phame Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
phid Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
phlux Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
pholio Warn in comment field if task is closed as duplicate 2024-06-23 15:29:17 +02:00
phortune Fix property name typo in PhabricatorPDFIterator 2024-07-12 12:20:19 +02:00
phpast Remove deprecated buildStandardPage* method calls 2024-05-16 08:39:08 +02:00
phrequent Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
phriction Fix missing file attachment in Phriction 2024-07-01 18:41:55 +02:00
phurl Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
policy Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
ponder Warn in comment field if task is closed as duplicate 2024-06-23 15:29:17 +02:00
project Removed unused renderStatus() from PhabricatorProjectSubprojectsController 2024-07-20 11:55:31 +02:00
reference/src Make the Remarkup Help Page Extensible 2024-06-26 22:11:44 +02:00
remarkup Generate file attachment transactions for explicit Remarkup attachments on common edit pathways 2022-05-19 13:21:04 -07:00
repository Remove unused shouldUse* functions from PhabricatorRepository 2024-08-29 10:25:56 +02:00
search Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
settings Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
slowvote Warn in comment field if task is closed as duplicate 2024-06-23 15:29:17 +02:00
spaces Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
subscriptions Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
support/application
system Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
tokens Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
transactions Remove trivial cases of unreachable code 2024-09-04 12:17:28 +02:00
typeahead Add missing variable names to PHPDoc @param of methods 2024-08-21 15:06:26 +02:00
uiexample Implements copy button in clone repo modal 2024-02-15 19:38:39 +01:00
xhprof Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00