Andre Klapper 43539b220c Remove trivial cases of unreachable code ... Summary: Static code analysis can detect `Unreachable statement - code above always terminates.` The vast majority of occurrences in the Phorge codebase are due to an unreachable `break` within a `case` after a `return` or after an all-covering `if/else`. All this noise makes it harder to spot real logic issues (there are some!), thus fix these trivial cases. Test Plan: Examine the code; run static code analysis. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25802		2024-09-04 12:17:28 +02:00
..
application	Allow EditEngine forms for objects which support subtyping to have a subtype configured	2017-03-02 04:18:06 -08:00
bulk	Fix spelling of etc. in messages per Translatewiki request	2024-05-25 11:51:48 -04:00
commentaction	When you "Request Review" of a draft revision, change the button text from "Submit Quietly" to "Publish Revision"	2018-11-15 20:50:21 -08:00
conduit	Correct spelling mistakes	2023-05-27 22:19:06 +01:00
constants	Fix missing file attachment in Conpherence	2024-07-05 18:20:40 +02:00
controller	Remove trivial cases of unreachable code	2024-09-04 12:17:28 +02:00
data	Generate file attachment transactions for explicit Remarkup attachments on common edit pathways	2022-05-19 13:21:04 -07:00
draft	Show yellow "draft" bubble in Audit	2017-01-16 10:28:59 -08:00
edges	Remove file attachment edge types, including API access	2022-05-19 13:21:04 -07:00
editengine	Add missing variable names to PHPDoc @param of methods	2024-08-21 15:06:26 +02:00
editfield	Add missing variable names to PHPDoc @param of methods	2024-08-21 15:06:26 +02:00
editor	Add missing variable names to PHPDoc @param of methods	2024-08-21 15:06:26 +02:00
edittype	Accept null via conduit.edit to unassign a task	2018-01-31 15:33:52 -08:00
engine	Declare missing class property in PhabricatorTimelineEngine	2024-07-10 14:54:31 +02:00
engineextension	Remove unused methods in PhabricatorEditorExtension	2024-07-02 17:55:25 +02:00
error	Allow users to unset "Editor", tailor short error messages properly on settings forms	2016-06-05 14:03:02 -07:00
exception	When users submit "editing" inlines, warn them that their inlines will be saved	2020-05-04 13:13:15 -07:00
feed	Separate "feed" and "notifications" better, allow stories to appear in notifications only	2018-12-10 16:02:43 -08:00
herald	Support "Subtype" in Herald	2019-09-12 14:34:06 -07:00
interface	Allow inline comment storage objects to generate their own runtime objects	2020-05-07 15:57:49 -07:00
phid	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
query	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
replyhandler	Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface	2018-12-20 15:16:19 -08:00
response	When users submit "editing" inlines, warn them that their inlines will be saved	2020-05-04 13:13:15 -07:00
storage	Remove trivial cases of unreachable code	2024-09-04 12:17:28 +02:00
typeahead	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
view	Warn in comment field if task is closed as duplicate	2024-06-23 15:29:17 +02:00
worker	Cache user notification and message counts	2016-06-05 08:52:43 -07:00
xaction	The feed "created this task" should be the first one	2024-05-18 10:05:35 +02:00