1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-18 11:30:55 +01:00
phorge-phorge/src/applications
epriestley b75a4151c8 Allow the fulltext index to select only transactions with comments
Summary:
Ref T12997. Although we can't query by transaction type (since we can't easily enumerate all possible types which may have comments -- inline types may also have comments), we //can// just check if there's a comment row or not.

This reduces the amount of garbage we need to load to rebuild indexes for unusual objects with hundreds and hundreds of mentions.

Test Plan:
  - Used batch editor to mention a task 700 times.
  - Indexed it before and after this change, saw index time drop from {nav 1600ms > 160ms}.
  - Made some new comments on it, verified that they still indexed/queried properly.
  - Browsed around, made normal transactions, made inline comments.
  - Added a unique word to an inline comment, indexed revision, searched for word, found revision.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T12997

Differential Revision: https://secure.phabricator.com/D18660
2017-09-28 12:55:23 -07:00
..
almanac Add edit methods for Almanac services and devices 2017-09-14 14:32:58 -07:00
aphlict Discard stdout/stderr from the aphlict subprocess when running in daemon (normal) mode 2016-11-13 16:43:42 -08:00
arcanist/conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
audit Build a page for viewing all inline comments 2017-06-12 11:31:20 -07:00
auth More completely explain why we're refusing to send reset mail to an unverified address 2017-09-20 10:46:22 -07:00
badges Spelling fix 2017-04-25 12:19:27 -07:00
base Update menu item names for Applications -> Favorites 2017-09-05 19:05:03 -07:00
cache When we purge the request cache, also force PHP to collect cycles 2017-09-28 12:37:22 -07:00
calendar Support Ferret engine in Calendar 2017-09-07 13:25:12 -07:00
celerity Add a red button to PHUIButtonView 2017-08-06 08:09:40 -07:00
chatlog Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
conduit Update Settings for WHITE_CONFIG style boxes 2017-09-05 19:42:34 -07:00
config Create revisions into "Draft", publish them when builds finish 2017-09-21 07:21:21 -07:00
conpherence Use Log In vs. Login when it's a verb 2017-08-02 12:26:47 -07:00
console Separate button CSS classes 2017-06-05 20:14:34 +00:00
countdown Remove old Countdown route 2017-04-13 13:04:55 -07:00
daemon Separate button CSS classes 2017-06-05 20:14:34 +00:00
dashboard Update Dashboards for new Edit UI 2017-09-05 20:17:18 -07:00
differential Create revisions into "Draft", publish them when builds finish 2017-09-21 07:21:21 -07:00
diffusion Fix an error in Diffusion when the Owners application is uninstalled 2017-09-19 09:42:42 -07:00
diviner Fix a constant typo in Diviner ("DECLARATAION" -> "TION") 2017-03-04 09:54:10 -08:00
doorkeeper Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
draft/storage Clean up some log spam caused by races in VersionedDraft 2016-09-05 13:01:53 -07:00
drydock Update drydock console, edit pages to new UI 2017-09-06 11:28:40 -07:00
fact Update Facts for newPage 2016-04-03 15:07:52 -07:00
favorites Add some style to label in Favorites Menu 2017-02-01 07:20:31 -08:00
feed Allow users to query feed by a date range 2017-05-26 12:23:56 -07:00
files Update file edit UI 2017-09-07 11:35:40 -07:00
flag Remove counts from home navigation 2017-01-21 13:55:40 -08:00
fund Reduce the amount of boilerplate that implementing FerretInterface requires 2017-09-07 13:23:31 -07:00
guides Make "simple" a "button type", not a "color" 2017-05-30 17:59:37 -07:00
harbormaster Use the correct "completed" time in Harbormaster display UI 2017-06-30 07:11:41 -07:00
help Redesign header menus and search 2017-01-17 12:13:06 -08:00
herald Update passphrase edit UI 2017-09-07 14:13:40 -07:00
home Update menu item names for Applications -> Favorites 2017-09-05 19:05:03 -07:00
legalpad Properly version Legalpad documents 2017-07-26 09:29:56 -07:00
lipsum Add "--force" and "--quickly" flags to bin/lipsum 2017-02-27 09:09:41 -08:00
macro Add Conduit edit endpoint for Macro 2017-05-10 14:54:43 -07:00
maniphest Correct an issue where Maniphest's awful legacy "reports" UI was extra broken on merges 2017-09-14 10:09:46 -07:00
meta Move setLaunchButton to setSideColumn for ObjectItem 2017-05-25 15:31:19 -07:00
metamta Queue a worker task to send mail only after committing the mail transaction 2017-06-14 12:27:00 -07:00
multimeter Add a cluster.read-only option 2016-04-09 13:40:47 -07:00
notification Make "No Notifications" setting less broad, and fix a bug with default display behavior 2017-09-13 15:32:46 -07:00
nuance Mark "Settings" and "Nuance" as launchable applications 2017-06-01 12:40:25 -07:00
oauthserver Update Settings for WHITE_CONFIG style boxes 2017-09-05 19:42:34 -07:00
owners Support Ferret engine in Owners 2017-09-07 13:23:46 -07:00
packages Fixing copy/paste mistake 2017-04-19 15:48:59 -07:00
passphrase Update passphrase edit UI 2017-09-07 14:13:40 -07:00
paste Fix bad "editPolicy" key in Paste 2017-04-05 13:09:51 -07:00
people Update an old SSH redirect URI when editing a bot's SSH keys 2017-09-20 14:46:31 -07:00
phame Support Ferret engine in Phame 2017-09-07 13:24:07 -07:00
phid Add Outline tag type to PHUITagView 2017-05-22 10:16:27 -07:00
phlux Update Phlux edit UI 2017-09-07 12:47:36 -07:00
pholio Support Ferret engine in Pholio 2017-09-07 13:25:29 -07:00
phortune Minor UX tweaks to Phortune autopay 2017-08-10 07:39:18 -07:00
phpast Update phpast for new UI 2016-04-05 13:52:59 -07:00
phragment Remove PhabricatorFile::buildFromFileDataOrHash() 2017-04-04 16:18:00 -07:00
phrequent Allow Phrequent to be used in dashboard panels 2017-03-06 11:00:55 -08:00
phriction Support Ferret engine in Phriction 2017-09-07 13:24:40 -07:00
phurl Change PhabricatorPhurlURLViewController to use EditEngine for commenting 2017-04-17 10:19:21 -07:00
policy Use a less-esoteric spelling of "capabilities" in several places 2017-07-12 15:27:57 -07:00
ponder Use Log In vs. Login when it's a verb 2017-08-02 12:26:47 -07:00
project Support Ferret engine in Projects 2017-09-07 13:24:23 -07:00
releeph Reduce callsites to "ArcanistDifferentialRevisionStatus" in Phabricator 2017-08-09 11:04:52 -07:00
remarkup/conduit phtize all the things 2015-05-22 21:16:39 +10:00
repository Update utility "bin/repository parents" workflow to work with RefPosition 2017-09-15 10:21:51 -07:00
search Improve performance of Ferret engine ngram extraction, particularly for large input strings 2017-09-27 10:41:39 -07:00
settings Update EditEngine pages to take a page header separate 2017-09-05 20:07:11 -07:00
slowvote Update slowvote for new edit UI 2017-09-07 12:51:59 -07:00
spaces Update Spaces for new edit UI 2017-09-07 11:33:59 -07:00
subscriptions Separate fulltext engine extensions into "enrich" and "index" phases 2017-09-01 09:40:11 -07:00
support/application Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
system When destorying a repository, print a notification about removing the working copy 2017-08-01 08:57:39 -07:00
tokens Prevent awarding/revoking tokens when a task is locked 2017-03-04 09:55:35 -08:00
transactions Allow the fulltext index to select only transactions with comments 2017-09-28 12:55:23 -07:00
typeahead Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine 2016-12-16 10:08:49 -08:00
uiexample Add a selected button ui state 2017-08-30 10:14:29 -07:00
xhprof Allow XHProf profiles to be drag-and-dropped to upload them 2017-02-23 11:16:19 -08:00