1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 23:32:40 +01:00
phorge-phorge/src/applications/paste
epriestley c125ab7a42 Remove "metamta.*.subject-prefix" options
Summary:
In ~2012, the first of these options was added because someone who hates dogs and works at Asana also hated `[Differential]` in the subject line. The use case there was actually //removing// the text, not changing it, but I made the prefix editable since it seemed like slightly less of a one-off.

These options are among the dumbest and most useless config options we have and very rarely used, see T11760. A very small number of instances have configured one of these options.

Newer applications stopped providing these options and no one has complained.

You can get the same effect with `translation.override`. Although I'm not sure we'll keep that around forever, it's a reasonable replacement today. I'll call out an example in the changelog to help installs that want to preserve this option.

If we did want to provide this, it should just be in {nav Applications > Settings} for each application, but I think it's wildly-low-value and "hack via translations" or "local patch" are entirely reasonable if you really want to change these strings.

Test Plan: Grepped for `subject-prefix`.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19993
2019-01-17 19:18:50 -08:00
..
application Update Phurl to use EditEngine 2016-09-20 09:38:49 -04:00
capability Paste: Add edit policy 2014-12-31 08:24:57 -08:00
conduit Fix "arc paste" to stop creating pastes with an empty string ("") as the "language" 2018-05-09 13:22:58 -07:00
controller Move Paste line range reading code into AphrontRequest 2018-03-01 11:15:06 -08:00
editor Remove "metamta.*.subject-prefix" options 2019-01-17 19:18:50 -08:00
engineextension Give "owners.search" a "paths" attachment and a default "owners" value 2015-12-14 11:53:50 -08:00
lipsum Fix Lipsum generators for Differential Revisions and Pastes 2018-07-23 15:05:51 -05:00
mail Remove "metamta.*.subject-prefix" options 2019-01-17 19:18:50 -08:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
query Get line count before truncating Paste snippets 2017-03-01 22:30:18 +00:00
remarkup Add some missing type hints 2015-05-05 07:33:00 +10:00
snippet Display paste line count alongside snippets 2017-01-26 19:06:23 -05:00
storage Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface 2018-12-20 15:16:19 -08:00
typeahead Converted Paste language selection to a typeahead 2016-08-30 00:41:47 +00:00
view Return $this from setter methods 2015-07-06 22:53:43 +10:00
xaction Remove the "willApplyTransactions()" hook from ApplicationTransactionEditor 2018-12-28 00:19:38 -08:00