mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-28 01:32:42 +01:00
2f11001f6e
Summary: Ref T13222. See PHI683. Currently, you can "Change subtype..." via Conduit and the bulk editor, but not via the comment action stack or edit forms. In PHI683 an install is doing this often enough that they'd like it to become a first-class action. I've generally been cautious about pushing this action to become a first-class action (there are some inevitable rough edges and I don't want to add too much complexity if there isn't a use case for it) but since we have evidence that users would find it useful and nothing has exploded yet, I'm comfortable taking another step forward. Currently, `EditEngine` has this sort of weird `setIsConduitOnly()` method. This actually means more like "this doesn't show up on forms". Make it better align with that. In particular, a "conduit only" field can already show up in the bulk editor, which is goofy. Change this to `setIsFormField()` and convert/simplify existing callsites. Test Plan: There are a lot of ways to reach EditEngine so this probably isn't entirely exhaustive, but I think I got pretty much anything which is likely to break: - Searched for `setIsConduitOnly()` and `getIsConduitOnly()`, converted all callsites to `setIsFormField()`. - Searched for `setIsLockable()`, `setIsReorderable()` and `setIsDefaultable()` and aligned these calls to intent where applicable. - Created an Almanac binding. - Edited an Almanac binding. - Created an Almanac service. - Edited an Almanac service. - Edited a binding property. - Deleted a binding property. - Created and edited a badge. - Awarded and revoked a badge. - Created and edited an event. - Made an event recurring. - Created and edited a Conpherence thread. - Edited and updated the diff for a revision. - Created and edited a repository. - Created and disabled repository URIs. - Created and edited a blueprint. - Created and edited tasks. - Created a paste, edited/archived a paste. - Created/edited/archived a package. - Created/edited a project. - Made comments. - Moved tasks on workboards via comment action stack. - Changed task subtype via comment action stack. Reviewers: amckinley Reviewed By: amckinley Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T13222 Differential Revision: https://secure.phabricator.com/D19842
116 lines
3.6 KiB
PHP
116 lines
3.6 KiB
PHP
<?php
|
|
|
|
final class PhabricatorPasteEditEngine
|
|
extends PhabricatorEditEngine {
|
|
|
|
const ENGINECONST = 'paste.paste';
|
|
|
|
public function getEngineName() {
|
|
return pht('Pastes');
|
|
}
|
|
|
|
public function getSummaryHeader() {
|
|
return pht('Configure Paste Forms');
|
|
}
|
|
|
|
public function getSummaryText() {
|
|
return pht('Configure creation and editing forms in Paste.');
|
|
}
|
|
|
|
public function getEngineApplicationClass() {
|
|
return 'PhabricatorPasteApplication';
|
|
}
|
|
|
|
protected function newEditableObject() {
|
|
return PhabricatorPaste::initializeNewPaste($this->getViewer());
|
|
}
|
|
|
|
protected function newObjectQuery() {
|
|
return id(new PhabricatorPasteQuery())
|
|
->needRawContent(true);
|
|
}
|
|
|
|
protected function getObjectCreateTitleText($object) {
|
|
return pht('Create New Paste');
|
|
}
|
|
|
|
protected function getObjectEditTitleText($object) {
|
|
return pht('Edit Paste: %s', $object->getTitle());
|
|
}
|
|
|
|
protected function getObjectEditShortText($object) {
|
|
return $object->getMonogram();
|
|
}
|
|
|
|
protected function getObjectCreateShortText() {
|
|
return pht('Create Paste');
|
|
}
|
|
|
|
protected function getObjectName() {
|
|
return pht('Paste');
|
|
}
|
|
|
|
protected function getCommentViewHeaderText($object) {
|
|
return pht('Eat Paste');
|
|
}
|
|
|
|
protected function getCommentViewButtonText($object) {
|
|
return pht('Nom Nom Nom Nom Nom');
|
|
}
|
|
|
|
protected function getObjectViewURI($object) {
|
|
return '/P'.$object->getID();
|
|
}
|
|
|
|
protected function buildCustomEditFields($object) {
|
|
return array(
|
|
id(new PhabricatorTextEditField())
|
|
->setKey('title')
|
|
->setLabel(pht('Title'))
|
|
->setTransactionType(PhabricatorPasteTitleTransaction::TRANSACTIONTYPE)
|
|
->setDescription(pht('The title of the paste.'))
|
|
->setConduitDescription(pht('Retitle the paste.'))
|
|
->setConduitTypeDescription(pht('New paste title.'))
|
|
->setValue($object->getTitle()),
|
|
id(new PhabricatorDatasourceEditField())
|
|
->setKey('language')
|
|
->setLabel(pht('Language'))
|
|
->setTransactionType(
|
|
PhabricatorPasteLanguageTransaction::TRANSACTIONTYPE)
|
|
->setAliases(array('lang'))
|
|
->setIsCopyable(true)
|
|
->setDatasource(new PasteLanguageSelectDatasource())
|
|
->setDescription(
|
|
pht(
|
|
'Language used for syntax highlighting. By default, inferred '.
|
|
'from the title.'))
|
|
->setConduitDescription(
|
|
pht('Change language used for syntax highlighting.'))
|
|
->setConduitTypeDescription(pht('New highlighting language.'))
|
|
->setSingleValue($object->getLanguage()),
|
|
id(new PhabricatorTextAreaEditField())
|
|
->setKey('text')
|
|
->setLabel(pht('Text'))
|
|
->setTransactionType(
|
|
PhabricatorPasteContentTransaction::TRANSACTIONTYPE)
|
|
->setMonospaced(true)
|
|
->setHeight(AphrontFormTextAreaControl::HEIGHT_VERY_TALL)
|
|
->setDescription(pht('The main body text of the paste.'))
|
|
->setConduitDescription(pht('Change the paste content.'))
|
|
->setConduitTypeDescription(pht('New body content.'))
|
|
->setValue($object->getRawContent()),
|
|
id(new PhabricatorSelectEditField())
|
|
->setKey('status')
|
|
->setLabel(pht('Status'))
|
|
->setTransactionType(
|
|
PhabricatorPasteStatusTransaction::TRANSACTIONTYPE)
|
|
->setIsFormField(false)
|
|
->setOptions(PhabricatorPaste::getStatusNameMap())
|
|
->setDescription(pht('Active or archived status.'))
|
|
->setConduitDescription(pht('Active or archive the paste.'))
|
|
->setConduitTypeDescription(pht('New paste status constant.'))
|
|
->setValue($object->getStatus()),
|
|
);
|
|
}
|
|
|
|
}
|