1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-25 23:10:57 +01:00
phorge-phorge/src/infrastructure/diff
epriestley 7b5e84282f Improve "thread" rendering of unusually-shaped graphs
Summary:
Ref T4788. This fixes all the bugs I was immediately able to catch:

  - "Directory-Like" graph shapes could draw too many vertical lines.
  - "Reverse-Directory-Like" graph shapes could draw too few vertical lines.
  - Terminated, branched graph shapes drew the very last line to the wrong place.

This covers the behavior with tests, so we should be able to fix more stuff later without breaking anything.

Test Plan:
  - Added failing tests and made them pass.

{F1708158}

{F1708159}

{F1708160}

{F1708161}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4788

Differential Revision: https://secure.phabricator.com/D16216
2016-07-01 11:15:24 -07:00
..
interface Allow inline comments to be individually hidden 2015-05-27 10:28:38 -07:00
query Publish draft "done" status when submitting comments/updates/actions/inlines 2015-03-24 05:26:12 -07:00
view Improve "thread" rendering of unusually-shaped graphs 2016-07-01 11:15:24 -07:00
PhabricatorChangesetResponse.php Reduce code duplication for inline "Undo" 2015-03-09 10:26:53 -07:00
PhabricatorDifferenceEngine.php Extend from Phobject 2015-06-15 18:02:27 +10:00
PhabricatorInlineCommentController.php When replying to a ghost comment, attach the reply to the same place 2016-03-10 16:41:49 -08:00
PhabricatorInlineCommentPreviewController.php Touch up PHP/JS interactions for inline comments 2015-03-27 17:08:31 -07:00