1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-11 17:32:41 +01:00
phorge-phorge/src/applications/repository
epriestley bd0011076b Don't disrupt repository import chain when publishing is disabled
Summary:
Fixes T4736. Currently, we incorrectly skip the `writeImportStatusFlag()` call if publishing is disabled (the `herald-disabled`) check. This means we don't flag the commit as imported, and don't move the pipeline forward correctly.

Instead, we only want to skip the owners stuff, not the pipeline stuff. Move that to a method.

(Also fix a nearby TODO now that we have a permanent failure exception.)

Test Plan:
  - Used `scripts/repository/reparse.php --owners ...` to execute this code, fiddled with things to hit both the disabled and enabled branches and verified the flag stuff is still reached.
  - Faked the exceptions and made sure they raise correctly.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4736

Differential Revision: https://secure.phabricator.com/D8715
2014-04-08 05:13:28 -07:00
..
application Ship "Repositories" create button to new Diffusion workflow 2013-10-29 15:32:39 -07:00
conduit Use "\z" instead of "$" to anchor validating regular expressions 2014-03-13 12:42:41 -07:00
constants Build an early multi-step repository create form 2013-07-14 07:37:17 -07:00
controller Fix Create New Repository link on Repositories 2014-02-16 20:12:09 -08:00
customfield Add a "tags" field to Diffusion commit 2014-03-12 11:30:52 -07:00
daemon Fix an issue which could prevent new repositories from being marked imported. 2014-01-30 09:43:53 -08:00
data Allow Git and Mercurial repositories to be cloned with names in the URI 2014-01-30 11:42:25 -08:00
editor Minor, fix a constant in PhabricatorRepositoryEditor 2014-03-26 10:45:48 -07:00
engine Added some additional assertion methods. 2014-03-08 19:16:21 -08:00
mail Allow users to receive email about pushes via Herald 2014-03-26 13:51:15 -07:00
management Separate repository mirroring into an Engine and provide bin/repository mirror 2014-01-25 14:01:58 -08:00
phid Differential - modernize "Local Commits" table 2014-04-02 13:18:11 -07:00
query Provide an "event" page for push logs, which shows details on all events in a given push 2014-03-26 13:51:09 -07:00
response Accept and route VCS HTTP requests 2013-10-29 15:32:40 -07:00
search Various linter fixes. 2014-02-26 12:44:58 -08:00
storage Differential - modernize "Local Commits" table 2014-04-02 13:18:11 -07:00
worker Don't disrupt repository import chain when publishing is disabled 2014-04-08 05:13:28 -07:00
PhabricatorRepositoryConfigOptions.php Raise a setup warning for missing or invalid local repository directory 2013-10-30 13:07:09 -07:00