1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 17:52:43 +01:00
phorge-phorge/src/applications/search
epriestley 3a87a95e11 Use ManiphestTaskQuery in nearly all interfaces
Summary:
Ref T603. Make almost every task read policy-aware. Notable exceptions are:

  - Edge editor -- this stuff is prescreened and should be moved to ApplicationTransactions eventually anyway.
  - Search/attach stuff -- this stuff needs some general work. The actual list should be fine since you can't pull handles. There may be a very indirect hole here where you could attach an object you can't see (but do know the ID of) to an object you can see. Pretty fluff.
  - The "Tasks" field in Differential will let you reference objects you can't see. Possibly this is desirable, in the case of commandeering revisions. Mostly, it was inconvenient to get a viewer (I think).

Test Plan:
  - Called `maniphest.info`.
  - Called `maniphest.update`.
  - Batch edited tasks.
  - Dragged and dropped tasks to change subpriority.
  - Subscribed and unsubscribed from a task.
  - Edited a task.
  - Created a task.
  - Created a task with a parent.
  - Created a task with a template.
  - Previewed a task update.
  - Commented on a task.
  - Added a dependency.
  - Searched for "T33" in object search dialog.
  - Created a branch "T33", ran `arc diff`, verified link.
  - Pushed a commit with "Fixes T33", verified close.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D7119
2013-09-25 13:44:14 -07:00
..
application Allow named queries to be reordered by dragging 2013-06-05 16:22:27 -07:00
config Search options. 2013-01-11 15:28:19 -08:00
constants Remove legacy "touched" table and indexing 2013-09-12 13:04:09 -07:00
controller Use ManiphestTaskQuery in nearly all interfaces 2013-09-25 13:44:14 -07:00
engine Add "user" and "users" standard custom fields 2013-09-16 16:04:46 -07:00
index Add event dispatch for updated search indexes 2013-09-12 13:05:54 -07:00
interface Provide PhabricatorSavedQuery to renderResultsList() 2013-07-03 05:46:04 -07:00
management Index projects in the main search index 2013-09-12 13:05:19 -07:00
query Introduce PhabricatorSavedQueryQuery 2013-05-27 13:41:20 -07:00
selector Delete license headers from files 2012-11-05 11:16:51 -08:00
storage Allow named queries to be reordered by dragging 2013-06-05 16:22:27 -07:00
view Simplify handle rendering in search view 2013-04-02 16:49:14 -07:00