1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-01 17:38:24 +01:00
phorge-phorge/src/applications/harbormaster/controller
epriestley bfaa93aa9b Allow Harbormaster build plans to request additional working copies
Summary:
Ref T9123. To run upstream builds in Harbormaster/Drydock, we need to be able to check out `libphutil`, `arcanist` and `phabricator` next to one another.

This adds an "Also Clone: ..." field to Harbormaster working copy build steps so I can type all three repos into it and get a proper clone with everything we need.

This is somewhat upstream-centric and a bit narrow, but I don't think it's totally unreasonable, and most of the underlying stuff is relatively general.

This adds some more typechecking and improves data/type handling for custom fields, too. In particular, it prevents users from entering an invalid/restricted value in a field (for example, you can't "Also Clone" a repository you don't have permission to see).

Test Plan: Restarted build, got a Drydock resource with multiple repositories in it.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9123

Differential Revision: https://secure.phabricator.com/D14183
2015-09-28 17:57:41 -07:00
..
HarbormasterBuildableActionController.php [harbormaster/abort-builds] Support aborting builds in Harbormaster 2015-09-21 12:07:38 -07:00
HarbormasterBuildableListController.php Increase visibility of PhabricatorController::buildApplicationMenu methods 2015-01-16 07:41:26 +11:00
HarbormasterBuildableViewController.php [harbormaster/abort-builds] Support aborting builds in Harbormaster 2015-09-21 12:07:38 -07:00
HarbormasterBuildActionController.php [harbormaster/abort-builds] Support aborting builds in Harbormaster 2015-09-21 12:07:38 -07:00
HarbormasterBuildViewController.php [harbormaster/abort-builds] Support aborting builds in Harbormaster 2015-09-21 12:07:38 -07:00
HarbormasterController.php Smooth out some UI/UX issues in Harbormaster 2015-06-23 10:23:35 -07:00
HarbormasterLintMessagesController.php Improve lint/unit limit, sort, view all, collapse behaviors 2015-06-23 13:34:25 -07:00
HarbormasterPlanController.php Fix method visibility for PhabricatorController subclasses 2015-01-07 07:34:59 +11:00
HarbormasterPlanDisableController.php Modernize some Harbormaster Controller/Policy infrastructure 2015-06-21 09:02:44 -07:00
HarbormasterPlanEditController.php Modernize some Harbormaster Controller/Policy infrastructure 2015-06-21 09:02:44 -07:00
HarbormasterPlanListController.php Modernize some Harbormaster Controller/Policy infrastructure 2015-06-21 09:02:44 -07:00
HarbormasterPlanRunController.php Don't let autoplans be run manually 2015-08-10 14:14:52 -07:00
HarbormasterPlanViewController.php Don't let autoplans be run manually 2015-08-10 14:14:52 -07:00
HarbormasterStepAddController.php Lump Harbormaster build steps into groups 2015-08-06 04:19:42 -07:00
HarbormasterStepDeleteController.php Modernize some Harbormaster Controller/Policy infrastructure 2015-06-21 09:02:44 -07:00
HarbormasterStepEditController.php Allow Harbormaster build plans to request additional working copies 2015-09-28 17:57:41 -07:00
HarbormasterUnitMessagesController.php [Redesign] Remove AphrontTable restriction on Search Engine 2015-06-29 12:28:55 -07:00