revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-07 12:28:28 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
Andre Klapper c0191a0392 Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/phortune/provider/PhortunePaymentProvider.php:99]
```

Closes T15725

Test Plan: See steps in T15725

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15725

Differential Revision: https://we.phorge.it/D25528
2024-01-27 09:20:37 +01:00
..
almanac Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
aphlict Aphlict - search for default config in the right place 2023-07-24 00:42:06 -07:00
arcanist/conduit
audit Hide "Packages" field in Diffusion Commits query form when application uninstalled 2024-01-06 16:26:01 +01:00
auth Auth SSH Details: show Public Key (not just Type) 2024-01-12 22:34:23 +01:00
badges Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
base Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
cache Fix various "strlen(null)" PHP 8.1 issues on "bin/phd" and "bin/drydock" pathways 2022-05-03 15:57:15 -07:00
calendar Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
celerity Teach ./bin/celerity about sprite maps 2023-06-03 09:57:05 -07:00
conduit Fix arc patch PHP 8.1 strlen(null) error 2023-07-29 17:36:13 +01:00
config Fix typo 2023-12-18 10:50:35 +01:00
conpherence Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
console log deprecation events in Dark Console 2023-08-31 08:18:28 -07:00
countdown Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
daemon Rebrand: Add "path" entries to PlatformSymbols 2023-08-18 02:00:41 -07:00
dashboard Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
differential Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
diffusion Updates for Mercurial's HTTP protocol 2023-11-30 20:16:03 -05:00
diviner Fix Diviner strlen(null) error when clicking on a link 2023-09-06 12:23:42 +01:00
doorkeeper Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
draft/storage Save drafts for inline comments currently being edited 2020-05-04 13:19:42 -07:00
drydock Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
fact Fix additional "xprintf()"-class static parameter lint errors 2020-09-08 11:45:48 -07:00
favorites Make "Favorites" work more like other customizable menus 2019-04-09 13:59:35 -07:00
feed Remove "feed.publish" API 2022-05-17 16:30:53 -07:00
files Avoid exception setting project profile image when GD not installed 2024-01-23 15:10:56 +01:00
flag Add a "Remove flag" action to Herald 2019-09-09 13:15:52 -07:00
fund Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
guides Remove product literal strings in "pht()", part 5 2022-04-25 12:22:27 -07:00
harbormaster Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
help Tokenize external editor links so they can be safely materialized on the client 2020-04-19 09:02:49 -07:00
herald Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
home Fix PHP 8.1 "strlen(null)" exception which blocks rendering the Home page 2023-05-01 15:37:56 +02:00
legalpad Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
lipsum Add "--force" and "--quickly" flags to bin/lipsum 2017-02-27 09:09:41 -08:00
macro Fix "Undefined index" exception setting Meme text 2023-10-24 09:58:36 +02:00
maniphest Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
meta Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
metamta Change some instances of "phabricator" to "phorge" 2023-11-18 22:14:15 +00:00
multimeter Fix PHP 8.1 "explode(null)" exception which blocks rendering the Multimeter page 2023-05-29 12:35:54 +02:00
notification Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument 2023-08-18 09:20:03 +02:00
nuance Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
oauthserver Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
owners Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
packages Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00
passphrase Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
paste Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
people Config User Extra Fields: link to the doc (like Maniphest) 2024-01-14 15:39:45 +01:00
phame Include 'published' date of posts in Phame Atom feeds 2023-12-06 11:34:38 -08:00
phid Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
phlux Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
pholio Fix exception in Transaction Log after renaming Pholio Mock image: Call to undefined method PholioImageSequenceTransaction::renderHandleLink() 2023-12-04 19:32:01 -08:00
phortune Fix PHP 8.1 "strlen(null)" exception creating a Merchant in Phortune 2024-01-27 09:20:37 +01:00
phpast
phrequent Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
phriction Fix PHP 8.1 "strlen(null)" exception creating a Phriction doc without slug in Conduit 2023-08-18 09:50:19 +02:00
phurl Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
policy Initialize static variable to make linter happy 2023-11-13 08:52:00 +08:00
ponder Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
project Fix project page 404 after rename and removing new name from alias slugs 2023-11-05 13:18:15 +01:00
remarkup Generate file attachment transactions for explicit Remarkup attachments on common edit pathways 2022-05-19 13:21:04 -07:00
repository Fix a PHP 8.1 deprecated use of strlen with a NULL argument in commit parser 2023-11-22 16:56:20 +01:00
search Various PHP 8.1 strlen(null) fixes for Dashboard Panels 2023-09-05 17:33:11 +01:00
settings Do not expose Contact Numbers settings panel when no SMS support configured 2023-11-13 14:04:16 +01:00
slowvote Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
spaces Show more in Application Detail and List view 2023-11-21 11:22:23 -07:00
subscriptions Remove product literal strings in "pht()", part 24 2022-04-25 16:46:26 -07:00
support/application
system Show Deprecation Warnings as Setup Warnings 2023-12-08 17:55:18 +02:00
tokens Fix cursor paging issue in Given Token query call 2023-11-09 21:01:02 +01:00
transactions Change some instances of "phabricator" to "phorge" 2023-11-18 22:14:15 +00:00
typeahead Fix PHP 8.1 null parameter exceptions which block rendering the "Browse Projects" overlay dialog 2023-05-20 17:48:53 +02:00
uiexample Improve command line prompts in setup issue pages 2023-12-07 16:22:24 +00:00
xhprof Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" 2022-05-24 10:18:53 -07:00