1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-30 17:30:59 +01:00
phorge-phorge/webroot/rsrc/css/phui
epriestley 1da54837ea Improve line breaking behavior in Firefox and Chrome under complex conditions
Summary: See <https://github.com/phacility/phabricator/pull/854>. In some situations, `line-break: anywhere` produces better behavior than `word-break: break-all`. It never appears to produce worse behavior.

Test Plan:
  - Break behavior changes if a line contains "<span />" elements caused by syntax highlighting. This CSS adjustment only appears to apply to text with internal "<span />" elements.
  - This specifically impacts certain internal breakpoints adjacent to punctuation, so the test case is highly specific. Generic test cases with latin word characters do not evidence any behavioral changes.
  - This change appears to have no impact on Safari, which uses the better behavior in all cases.
  - Before Patch: In Firefox and Chrome, this specific change breaks awkwardly. There is more room for text to fit on the broken line:

Firefox

{F7480567}

Chrome

{F7480568}

  - After Patch: Firefox and Chrome break the line better. Here's Firefox:

{F7480569}

  - Additional context:

Safari Behavior (Unchanged)

{F7480570}

Chrome with no highlighting (desirable behavior). Firefox does the same thing.

{F7480571}

Also tested other cases, which seem never-worse in any browser.

{F7480574}

Differential Revision: https://secure.phabricator.com/D21247
2020-05-13 11:54:42 -07:00
..
button Allow Phriction document edits to be saved as drafts 2018-09-12 13:30:40 -07:00
calendar Add an Experimental Dark Mode to Phabricator 2017-07-18 06:44:32 -07:00
object-item Make "Move Panel" on dashboards use the new storage and transactions 2019-04-14 10:25:22 -07:00
workboards Work around rendering engine freeze in Chrome 77 affecting workboards 2019-09-12 19:04:41 -07:00
phui-action-list.css Update the "View Options" menu for recent filetree changes 2020-04-23 08:23:12 -07:00
phui-action-panel.css Add setImage to PHUIActionPanelView 2017-07-30 13:20:26 -07:00
phui-badge.css Build a Badges page for Profiles 2017-02-24 13:15:42 -08:00
phui-basic-nav-view.css Align sidenavs better, use sky to highlight 2017-08-28 16:36:41 -07:00
phui-big-info-view.css Allow images to be used with PHUIBigInfoView 2017-08-03 18:56:19 -07:00
phui-box.css Make bulk editor working set editable and more homogenous 2018-01-19 12:39:27 -08:00
phui-bulk-editor.css Restore bulk edit support for remarkup fields (description, add comment) 2018-01-19 12:45:34 -08:00
phui-chart.css In stacked area charts, group nearby points so they don't overlap 2019-09-17 09:26:54 -07:00
phui-cms.css Rough in of NUX Guide steps 2016-08-20 14:05:12 -07:00
phui-comment-form.css Lots of little fixes for Dark Mode (Experimental) 2017-07-19 14:41:23 -07:00
phui-comment-panel.css Hide badges in phui-comment-panel 2016-12-02 11:02:53 -08:00
phui-crumbs-view.css Allow navigation breadcrumbs to be marked as "always visible" so they show up on phones 2018-05-09 13:21:47 -07:00
phui-curtain-object-ref-view.css Use the new "CurtainObjectRefList" UI element for subscribers 2020-02-04 12:38:41 -08:00
phui-curtain-view.css Make PHUITwoColumnView a little more printable 2017-09-25 19:56:22 +00:00
phui-document-pro.css Fix "Actions" button on Phame standalone/live pages (bonus: JX.sprintf()) 2019-04-04 06:10:14 -07:00
phui-document-summary.css Add an Experimental Dark Mode to Phabricator 2017-07-18 06:44:32 -07:00
phui-document.css Add a UI element for navigating between versions of a Phriction document 2018-08-29 13:49:15 -07:00
phui-feed-story.css Remove box-shadow from feed story actors 2016-10-11 11:15:02 -07:00
phui-fontkit.css Differentiate Remarkup header sizes more clearly 2019-06-04 16:03:32 -07:00
phui-form-view.css When users confirm Duo MFA in the mobile app, live-update the UI 2019-02-15 14:38:15 -08:00
phui-form.css Fix two issues with missing whitespace when elements stack on top of each other while wrapping 2020-01-15 08:52:56 -08:00
phui-formation-view.css Stick the page footer in the right place on Formation View pages 2020-04-24 11:25:31 -07:00
phui-head-thing.css Update Diffusion UI 2016-03-17 12:05:14 -07:00
phui-header-view.css Fix two issues with missing whitespace when elements stack on top of each other while wrapping 2020-01-15 08:52:56 -08:00
phui-hovercard.css Improve text overflow behavior for hovercards with (for example) long package names 2018-11-15 20:43:10 -08:00
phui-icon-set-selector.css Add more color/CSS to phui-icon-selector 2017-02-04 10:13:32 -08:00
phui-icon.css When an edit overrides an object lock, note it in the transaction record 2019-02-09 06:10:07 -08:00
phui-image-mask.css Move rgba rules into CelerityDefaultPostprocessor 2016-02-16 09:54:43 -08:00
phui-info-view.css Some formatting changes for showing auth provider config guidance 2019-04-17 11:08:16 -07:00
phui-invisible-character-view.css Add an Experimental Dark Mode to Phabricator 2017-07-18 06:44:32 -07:00
phui-left-right.css Update Diffusion File UI for single column 2017-08-21 13:35:25 -07:00
phui-lightbox.css Add an Experimental Dark Mode to Phabricator 2017-07-18 06:44:32 -07:00
phui-list.css Make the "Keyboard Shortcuts" dialog in Differential less hideous 2020-04-19 09:01:07 -07:00
phui-object-box.css Update Herald rule creation workflow to use more modern UI elements 2020-02-04 07:37:54 -08:00
phui-pager.css Add a selected color state to PHUIPagerView 2017-06-06 17:00:39 -07:00
phui-pinboard-view.css Add an Experimental Dark Mode to Phabricator 2017-07-18 06:44:32 -07:00
phui-policy-section-view.css Inline custom policy rules inside policy capability explanation dialogs 2019-09-12 09:40:50 -07:00
phui-property-list-view.css Improve line breaking behavior in Firefox and Chrome under complex conditions 2020-05-13 11:54:42 -07:00
phui-remarkup-preview.css Clean up Remarkup Preview on mobile 2017-04-17 22:11:08 +00:00
phui-segment-bar-view.css Redesign Home/Profile/Projects side navigation 2017-01-31 08:59:01 -08:00
phui-spacing.css PHUIButtonView class 2013-06-12 18:23:35 -07:00
phui-status.css New icons, colors for per reviewer status 2016-05-01 12:52:40 -07:00
phui-tag-view.css Update search indexes for Dashboards and Panels to Ferret, plus various minor fixes 2019-04-14 10:28:19 -07:00
phui-timeline-view.css Restore highlighting when jumping to transactions using URI anchors 2020-05-04 10:04:04 -07:00
phui-two-column-view.css Move existing "Console" interfaces away from "setFixed(...)" on "TwoColumnView" 2020-02-04 06:52:23 -08:00