revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 18:22:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
Andre Klapper c1d86da5b2 Initialize $cache_key variable in CelerityResourceController.php 
Summary:
`$cache_key` is unconditionally called in `$cache->setKey($cache_key, $data)` but is only defined if the previous condition `if ($is_cacheable && $is_locally_cacheable && !$dev_mode)` was true.
Thus initialize the variable to avoid a theoretical exception. (No additional null check is needed as `$cache` gets defined in the same condition.)

Test Plan: Carefully read the code.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25642
2024-06-11 13:54:58 +02:00
..
almanac Fix PHP 8.1 "strlen(null)" exception for "/bin/almanac register" without parameter 2024-04-17 13:12:16 +02:00
aphlict Fix PHP 8.1 "strlen(null)" exception for "/bin/aphlict notify" without parameter 2024-04-17 13:11:07 +02:00
arcanist/conduit
audit Allow to uninstall (hide) Audit application 2024-02-12 12:10:06 +01:00
auth Fix a leftover misspelled "Phabricator" reference 2024-06-06 10:36:51 -04:00
badges Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
base Remove deprecated buildStandardPage* method calls 2024-05-16 08:39:08 +02:00
cache Fix various "strlen(null)" PHP 8.1 issues on "bin/phd" and "bin/drydock" pathways 2022-05-03 15:57:15 -07:00
calendar Fix PHP 8.1 exceptions importing ICS file without attendee names 2024-06-11 00:54:38 +02:00
celerity Initialize $cache_key variable in CelerityResourceController.php 2024-06-11 13:54:58 +02:00
conduit Fix PHP 8.1 "strlen(null)" exception for "/bin/conduit call" without parameter 2024-04-17 13:07:30 +02:00
config Fix spelling of etc. in messages per Translatewiki request 2024-05-25 11:51:48 -04:00
conpherence Fix PHP 8.1 "strlen(null)" exception rendering Conpherence search results 2024-05-09 14:42:13 +02:00
console log deprecation events in Dark Console 2023-08-31 08:18:28 -07:00
countdown Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
daemon Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
dashboard Fix PHP 8.1 "strlen(null)" exceptions editing existing Dashboard query panel with no query defined 2024-06-07 13:32:33 +02:00
differential Show login page if a search token requires a valid viewer 2024-06-04 16:10:50 +02:00
diffusion Fix call to non-existing getDisplayName() in DiffusionRepositoryClusterEngine.php 2024-06-07 13:30:15 +02:00
diviner Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
doorkeeper Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
draft/storage Save drafts for inline comments currently being edited 2020-05-04 13:19:42 -07:00
drydock Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
fact Facts: Fix displaying charts for anonymous users 2024-05-05 17:35:35 +02:00
favorites Make "Favorites" work more like other customizable menus 2019-04-09 13:59:35 -07:00
feed Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
files Fix call to non-existing newIcons() in PhabricatorIconSet 2024-06-05 17:15:45 +02:00
flag Add (Advanced) Custom Fields to Item List 2024-05-11 13:25:41 +03:00
fund Deprecate Fund and Phortune prototype applications 2024-02-06 09:16:19 +01:00
guides Remove product literal strings in "pht()", part 5 2022-04-25 12:22:27 -07:00
harbormaster Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
help Tokenize external editor links so they can be safely materialized on the client 2020-04-19 09:02:49 -07:00
herald Remove unused variable from HeraldEngine 2024-06-05 10:30:05 +02:00
home Fix PHP 8.1 "strlen(null)" exception which blocks rendering the Home page 2023-05-01 15:37:56 +02:00
legalpad Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
lipsum Add "--force" and "--quickly" flags to bin/lipsum 2017-02-27 09:09:41 -08:00
macro Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
maniphest Expose initially set values of Maniphest custom date field and point values when removing them 2024-06-03 15:43:27 +02:00
meta Fix important regression in search engine 2024-03-26 07:30:10 +01:00
metamta Correct PHPDoc return value for loadObject() in PhabricatorObjectMailReceiver 2024-06-05 17:17:35 +02:00
multimeter Fix PHP 8.1 "explode(null)" exception which blocks rendering the Multimeter page 2023-05-29 12:35:54 +02:00
notification Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
nuance Fix call to non-existing newWorkCommands() in NuanceItemType 2024-06-07 13:30:49 +02:00
oauthserver Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
owners Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
packages Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
passphrase Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
paste Fix PHP 8.1 "strlen(null)" exception in PhabricatorPasteLanguageTransaction.php 2024-05-02 10:28:08 +02:00
people Only display "Calendar" entry in user profile page menu on mobile when Calendar application is installed 2024-06-08 10:02:07 +02:00
phame Correct PHPDoc or add default return for numerous methods 2024-05-18 21:54:51 +02:00
phid Correct docs of PhabricatorPHIDType::getAllTypesForApplication() 2024-04-08 13:14:01 +02:00
phlux Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
pholio Mark created Pholio mockups as new objects to fix empty Feed transaction entries 2024-05-09 11:04:37 +02:00
phortune Improve messages when no image formats are supported (due to GD not installed) 2024-02-13 17:06:57 +01:00
phpast Remove deprecated buildStandardPage* method calls 2024-05-16 08:39:08 +02:00
phrequent Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
phriction Fix an instance of strlen(null) 2024-02-23 17:06:26 +02:00
phurl Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
policy Fix the whitespace issue in the message "Access Denied: Restricted File" 2024-05-05 14:00:26 +03:00
ponder Fix PonderQuestionCreateMailReceiver accessing non-existing PonderQuestionTransaction constants 2024-05-18 21:41:04 +02:00
project Show login page if a search token requires a valid viewer 2024-06-04 16:10:50 +02:00
remarkup Generate file attachment transactions for explicit Remarkup attachments on common edit pathways 2022-05-19 13:21:04 -07:00
repository fix PHP 8 "strlen(null)" when moving paths with missing options 2024-02-12 11:05:31 +01:00
search Show login page if a search token requires a valid viewer 2024-06-04 16:10:50 +02:00
settings Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
slowvote Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
spaces Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
subscriptions Remove product literal strings in "pht()", part 24 2022-04-25 16:46:26 -07:00
support/application
system Show Deprecation Warnings as Setup Warnings 2023-12-08 17:55:18 +02:00
tokens Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
transactions Fix spelling of etc. in messages per Translatewiki request 2024-05-25 11:51:48 -04:00
typeahead Show login page if a search token requires a valid viewer 2024-06-04 16:10:50 +02:00
uiexample Implements copy button in clone repo modal 2024-02-15 19:38:39 +01:00
xhprof Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00