1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 14:30:56 +01:00
phorge-phorge/src/infrastructure
epriestley 13dd3014a7 Fix loop in QueryIterator when row count is an exact multiple of page size
Summary: Ref T13152. The pager does a bit of magic here and doesn't populate `nextPageID` when it knows it got an exact final page. The logic misfired in this case and sent us back to the start.

Test Plan:
  - Set page size to 1 to guarantee rows were an exact multiple of page size.
  - Ran `rebuild-identities` (I no-op'd the actual logic to make it faster).
  - Before: looped forever.
  - After: clean exit after processing everything.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13152

Differential Revision: https://secure.phabricator.com/D19479
2018-06-07 13:17:34 -07:00
..
cluster When database connection exceptions occur, raise them to the setup layer 2018-05-18 09:02:36 -07:00
contentsource Redesign Config Application 2016-08-29 15:49:49 -07:00
customfield Provide comment actions for tokenizer custom fields 2018-03-29 14:10:15 -07:00
daemon Add a "lock log" for debugging where locks are being held 2018-03-05 17:55:34 -08:00
diff Truncate package names in diff table of contents views 2018-06-07 13:17:01 -07:00
edges Add a bit of test coverage for bulky vs compact edge data representations 2018-01-29 11:34:57 -08:00
env Fix spelling 2017-10-09 10:48:04 -07:00
events Modernize Hovercard implementation 2015-12-24 12:18:28 -08:00
export Export task point values as double, not int 2018-05-08 15:49:40 -07:00
graph Enable hovercards for the "Task Graph" UI in Maniphest 2017-10-04 11:12:01 -07:00
internationalization In Differential, prevent "Accept" and "Reject" from "Plan Changes + Draft" 2018-04-23 14:39:36 -07:00
javelin When the profiler is active, keep it active if the user submits forms 2017-02-23 11:15:40 -08:00
lint/linter Linter fixes 2015-12-03 07:44:23 +11:00
log Add "%I" (instance name) to application log formats 2017-04-23 11:07:19 -07:00
management Provide "bin/files integrity" for debugging, maintaining and backfilling integrity hashes 2017-04-06 15:42:43 -07:00
markup Fix YouTube remarkup rule being blocked by Content-Security-Policy header 2018-04-02 16:11:02 -07:00
query Support some QueryConstraint operations against generic ApplicationSearch query logic 2018-02-22 12:49:49 -08:00
sms Various linter fixes 2015-08-11 22:36:55 +10:00
ssh Generate a random unique "Request ID" for SSH requests so processes can coordinate better 2018-03-22 13:44:30 -07:00
status Give Drydock Leases more modern status treatment 2018-02-13 13:15:57 -08:00
storage Fix loop in QueryIterator when row count is an exact multiple of page size 2018-06-07 13:17:34 -07:00
syntax Pass the new default syntax highlighting map to the remarkup engine 2016-05-05 02:51:19 -07:00
testing When running unit tests, ignore any custom task fields 2017-04-02 09:36:17 -07:00
time Fix errors found by PHPStan 2017-02-18 09:24:56 +00:00
util Add a "lock log" for debugging where locks are being held 2018-03-05 17:55:34 -08:00
PhabricatorEditor.php Mark some strings for translation 2015-06-09 23:06:52 +10:00