1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 02:12:41 +01:00
phorge-phorge/src/applications/herald
epriestley 8d048f06ab Fix a Herald issue where testing commits against rules with revision-related conditions would fail
Summary:
Fixes T11610. Clean up some sketchy old code from long ago.

If you had rules that use conditions like "Accepted revision exists" and ran them in the test console, we'd never load the "CommitData" and fatal.

Instead, load CommitData in `newTestAdapter()` and generally make these pathways a little more modern.

Test Plan:
  - Wrote an "Accepted Revision Exists" rule.
  - Ran a commit in the test console.
  - Before patch, got fatal from T11610.
  - After patch, got clean test result.
  - Also pushed a commit and reviewed the transcript to make sure the rule ran properly.

Reviewers: joshuaspence, chad

Reviewed By: chad

Maniphest Tasks: T11610

Differential Revision: https://secure.phabricator.com/D16522
2016-09-08 17:16:40 -07:00
..
action Allow "Assign task" Herald Action in Maniphest to accept "None" to unassign 2015-12-05 12:39:45 -08:00
adapter Fix a Herald issue where testing commits against rules with revision-related conditions would fail 2016-09-08 17:16:40 -07:00
application Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
config Extend from Phobject 2015-06-15 18:02:27 +10:00
contentsource Modularize content sources 2016-03-26 11:59:45 -07:00
controller Fix a Herald issue where testing commits against rules with revision-related conditions would fail 2016-09-08 17:16:40 -07:00
editor Drive Herald edits via transactions 2016-03-28 23:02:41 +00:00
engine Fix an issue with the Herald engine field value cache 2016-03-09 10:28:50 -08:00
engineextension Fully modularize DestructionEngine 2015-12-21 17:03:44 -08:00
field Allow Herald text list fields to use "Exists" / "Does not exist" conditions 2016-06-21 15:27:43 -07:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
group Make Herald action modularization more aggressive 2015-08-03 14:33:20 -07:00
phid Add PHIDType for HeraldTransaction 2016-01-15 16:40:48 +00:00
query Search builds based on who kicked them off 2016-07-31 20:54:44 +00:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
storage Let everyone view Herald rules 2016-08-10 08:52:36 -07:00
typeahead Search builds based on who kicked them off 2016-07-31 20:54:44 +00:00
value Improve rendering of tokenizer tokens in Herald when editing rules 2015-12-05 11:20:07 -08:00