epriestley 8d048f06ab Fix a Herald issue where testing commits against rules with revision-related conditions would fail ... Summary: Fixes T11610. Clean up some sketchy old code from long ago. If you had rules that use conditions like "Accepted revision exists" and ran them in the test console, we'd never load the "CommitData" and fatal. Instead, load CommitData in `newTestAdapter()` and generally make these pathways a little more modern. Test Plan: - Wrote an "Accepted Revision Exists" rule. - Ran a commit in the test console. - Before patch, got fatal from T11610. - After patch, got clean test result. - Also pushed a commit and reviewed the transcript to make sure the rule ran properly. Reviewers: joshuaspence, chad Reviewed By: chad Maniphest Tasks: T11610 Differential Revision: https://secure.phabricator.com/D16522		2016-09-08 17:16:40 -07:00
..
HeraldController.php	Add more NUX states	2015-12-21 11:15:54 -08:00
HeraldDisableController.php	Use monograms for Herald URIs	2015-11-13 07:07:00 +11:00
HeraldNewController.php	Update Herald edit/transcripts to modern UI	2016-04-01 14:14:25 +00:00
HeraldRuleController.php	Update Herald edit/transcripts to modern UI	2016-04-01 14:14:25 +00:00
HeraldRuleListController.php	Update Herald for handleRequest	2015-08-01 15:41:36 -07:00
HeraldRuleViewController.php	Let everyone view Herald rules	2016-08-10 08:52:36 -07:00
HeraldTestConsoleController.php	Fix a Herald issue where testing commits against rules with revision-related conditions would fail	2016-09-08 17:16:40 -07:00
HeraldTranscriptController.php	Link Herald rules to rule detail pages in Herald transcripts	2016-08-10 08:53:03 -07:00
HeraldTranscriptListController.php	Modernize Herald	2015-11-30 07:11:52 -08:00