epriestley d1225e782b Don't try to load user profile images in PhabricatorPeopleQuery if no users have any ... Summary: Fixes T3810. In PhabricatorPeopleQuery, we issue an unnecessary query like this: SELECT f.* FROM file f WHERE (f.phid IN ('')) ORDER BY f.id DESC ...if we're loading a user without a profile picture. Filter the file PHIDs before loading them to prevent this. This doesn't change anything, but saves us a spurious/silly query. Also makes `PhabricatorPeopleProfileController` use `needProfileImage()`, moving us closer to getting rid of `loadProfileImageURI()` eventually. Test Plan: Looked at profiles of users with and without profile pictures. Checked query log in DarkConsole. Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T3810 Differential Revision: https://secure.phabricator.com/D6913		2013-09-08 09:43:27 -07:00
..
PhabricatorPeopleController.php	Drive auth config with the database	2013-06-20 11:18:11 -07:00
PhabricatorPeopleEditController.php	Update Form Layouts	2013-08-26 11:53:11 -07:00
PhabricatorPeopleLdapController.php	Remove dust from page construction	2013-08-19 18:09:35 -07:00
PhabricatorPeopleListController.php	Provide PhabricatorSavedQuery to renderResultsList()	2013-07-03 05:46:04 -07:00
PhabricatorPeopleLogsController.php	Made most of People inaccessible for passer-bys	2013-03-19 13:48:58 -07:00
PhabricatorPeopleProfileController.php	Don't try to load user profile images in PhabricatorPeopleQuery if no users have any	2013-09-08 09:43:27 -07:00
PhabricatorPeopleProfileEditController.php	Update Form Layouts	2013-08-26 11:53:11 -07:00
PhabricatorPeopleProfilePictureController.php	Update forms to use PHUIFormBoxView	2013-08-26 15:45:58 -07:00