1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 23:02:42 +01:00
phorge-phorge/webroot/rsrc
epriestley d161a07781 Improve Differential behavior when scrolling with anchors
Summary:
Fixes T12779. Currently, we scroll down if the midline of the changeset is above the midline of the viewport.

This rule can cause us to scroll improperly when loading changesets //after// jumping to their anchors, since the changeset we want to look at will likely have a midpoint above the document midline. That is, we follow an anchor to `X.c`, then it loads, then we scroll past it.

Instead, scroll only if the changeset is (almost) entirely above the viewport.

Test Plan:
Followed an anchor to `PHUIFeedStoryExample`:

{F4984154}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12779

Differential Revision: https://secure.phabricator.com/D18052
2017-05-30 17:56:03 -07:00
..
audio/basic Add a few more sounds 2017-04-19 13:47:23 -07:00
css Use a list view for DiffusionHistory 2017-05-30 17:31:48 -07:00
externals Hide the Differential scroll objective list on trackpad systems 2017-05-20 07:56:21 -07:00
favicons JX.Favicon for Conpherence 2016-10-20 12:17:50 -07:00
image Add some higher resolution default user images 2017-02-26 09:56:21 -08:00
js Improve Differential behavior when scrolling with anchors 2017-05-30 17:56:03 -07:00