1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-22 03:29:11 +01:00
phorge-phorge/webroot/rsrc/js
epriestley d161a07781 Improve Differential behavior when scrolling with anchors
Summary:
Fixes T12779. Currently, we scroll down if the midline of the changeset is above the midline of the viewport.

This rule can cause us to scroll improperly when loading changesets //after// jumping to their anchors, since the changeset we want to look at will likely have a midpoint above the document midline. That is, we follow an anchor to `X.c`, then it loads, then we scroll past it.

Instead, scroll only if the changeset is (almost) entirely above the viewport.

Test Plan:
Followed an anchor to `PHUIFeedStoryExample`:

{F4984154}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12779

Differential Revision: https://secure.phabricator.com/D18052
2017-05-30 17:56:03 -07:00
..
application Improve Differential behavior when scrolling with anchors 2017-05-30 17:56:03 -07:00
core Fix lightbox circle icons 2017-05-26 20:12:56 -07:00
phui Attempt to make dropdown item actions more consistent 2017-01-18 13:14:54 -08:00
phuix Fix autocomplete/send-on-enter interactions 2017-04-26 08:48:25 -07:00