revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 08:12:40 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley d1eed54d85 Fix expansion of projects into lists of user PHIDs 
Summary:
Ref T11016. I think I inverted the meaning of this function by accident in D14893.

The intent is to return a list of users: direct users, and all members of all projects.

Prior to this patch actually returns direct users, and all projects they are members of.

Test Plan:
  - Created "Project with Dog".
  - Added user "dog" to project.
  - Created package "X", owning file "/x", with audit enabled.
  - Made "X" owned by "Project with Dog".
  - Modified "/x" and had user "dog" accept it.
  - Landed change.
  - Prior to change: package "X" incorrectly added as auditor.
  - After change: package "X" correctly omitted as auditor, because a member reviewed the change.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11016

Differential Revision: https://secure.phabricator.com/D15971
2016-05-24 06:38:37 -07:00
..
almanac Send forced mail on SSH key edits 2016-05-19 15:01:25 -07:00
aphlict Fix bad variable causing aphlict to fail to start with no "logs" config 2016-04-24 11:20:42 -07:00
arcanist/conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
audit Don't send mail to "uninteresting" auditors 2016-05-23 17:55:13 -07:00
auth Fix minor section formatting mishap in SSH key email 2016-05-19 15:20:19 -07:00
badges Fix header in Badges 2016-04-13 20:44:43 -07:00
base Split Repository EditEngine form into smaller pages 2016-05-02 08:28:38 -07:00
cache Automatically sever databases after prolonged unreachability 2016-04-11 08:43:52 -07:00
calendar Remove "days fresh" / "days stale" indictator in Differential revision list 2016-05-16 10:47:19 -07:00
celerity Generate syntax highlighting CSS from a reusable map 2016-05-05 02:50:48 -07:00
chatlog Update chatlog to newPage() 2016-04-02 13:20:55 -07:00
conduit Deactivate SSH keys instead of destroying them completely 2016-05-18 14:54:28 -07:00
config Remove "days fresh" / "days stale" indictator in Differential revision list 2016-05-16 10:47:19 -07:00
conpherence Allow users to be banished from Conpherence rooms 2016-04-15 14:57:29 -07:00
console Separate external editor integration from callsigns 2016-01-04 06:54:01 -08:00
countdown Support sorting countdowns by end date 2016-04-07 12:37:55 -07:00
daemon Fail explicitly instead of continuing with a warning if "phd.user" is misconfigured 2016-04-15 14:09:13 -07:00
dashboard Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
differential Fix "Reviewers" validation issue with empty reviewers 2016-05-23 17:16:21 -07:00
diffusion Fix a possible fatal on the first push to a cluster repository 2016-05-23 17:54:54 -07:00
diviner Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
doorkeeper Bridge GitHub users into Phabricator and attribute actions to them 2016-03-28 13:10:32 -07:00
draft/storage Fix EditEngine preview/draft for first comment on a task you didn't create 2015-12-05 09:57:45 -08:00
drydock Add icons to the new repository edit nav 2016-05-03 08:01:18 -07:00
fact Update Facts for newPage 2016-04-03 15:07:52 -07:00
feed Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
files Provide an <input type="file"> control in Remarkup for mobile and users with esoteric windowing systems 2016-05-20 16:24:22 -07:00
flag Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
fund Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
harbormaster Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
help Update Help for newPage 2016-04-05 07:26:31 -07:00
herald Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
home Use new Differential bucketing logic on default (non-dashboard) homepage 2016-05-19 15:20:39 -07:00
legalpad Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
lipsum Modularize content sources 2016-03-26 11:59:45 -07:00
macro Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
maniphest Modernize DifferentialRevisionSearchEngine 2016-05-16 10:44:11 -07:00
meta Give application actors in feed reasonable icons 2016-04-20 14:38:55 -07:00
metamta Send HTML email by default 2016-05-18 14:53:57 -07:00
multimeter Add a cluster.read-only option 2016-04-09 13:40:47 -07:00
notification Support Aphlict clustering 2016-04-14 13:26:30 -07:00
nuance Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
oauthserver Add missing "oauth_server_edge" tables 2016-05-17 08:50:27 -07:00
owners Fix expansion of projects into lists of user PHIDs 2016-05-24 06:38:37 -07:00
passphrase Prevent locked credentials from being made accessible via conduit 2016-05-18 14:54:44 -07:00
paste Add badges.edit and badges.search to Conduit API 2016-04-05 16:25:55 -07:00
people Remove calendar panel in profile and make calendar box header a link to user's calendar 2016-05-23 11:32:56 -07:00
phame Update EditEngine for two column 2016-03-28 09:18:55 -07:00
phid Allow blocking reviewers to be added via the CLI 2016-05-17 10:56:29 -07:00
phlux Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
pholio Add transparency to Pholio Edit thumbs 2016-05-20 13:43:22 -07:00
phortune Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
phpast Update phpast for new UI 2016-04-05 13:52:59 -07:00
phragment Moderize Phragment 2016-04-02 14:24:40 +00:00
phrequent Add a Phrequent curtain extension 2016-03-10 18:45:04 -08:00
phriction Fix Phriction link syntax a little more 2016-04-21 10:29:08 -07:00
phurl Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
policy Simplify locking of Almanac cluster services 2016-02-25 03:38:39 -08:00
ponder Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
project Clean up "points" display on workboards 2016-05-20 13:06:57 -07:00
releeph Update Releeph to new UI 2016-04-05 13:16:10 -07:00
remarkup/conduit phtize all the things 2015-05-22 21:16:39 +10:00
repository Improve audit behavior for "uninteresting" auditors 2016-05-17 13:47:33 -07:00
search Fix weird remarkup linewrapping on a few instructions forms, plus move toward fixing Phame/CORGI remarkup issues 2016-05-22 12:23:05 -07:00
settings Wordsmith the timezone selection UX 2016-05-23 10:31:42 -07:00
slowvote Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
spaces Normalize casing on property boxes 2016-04-06 15:33:15 -07:00
subscriptions Allow stacked comment actions to be explicitly ordered 2016-04-06 09:15:27 -07:00
support/application Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
system Two-for-one deal on typos 2016-05-18 09:53:39 -07:00
tokens Update Tokens for newPage 2016-04-02 13:22:24 -07:00
transactions Fix weird remarkup linewrapping on a few instructions forms, plus move toward fixing Phame/CORGI remarkup issues 2016-05-22 12:23:05 -07:00
typeahead Modernize "Responsible Users" tokenizer and add "exact(user)" token 2016-05-16 10:46:26 -07:00
uiexample Fixing UI Example that use badge qualities 2016-04-15 11:05:45 -07:00
xhprof Update XHProf for newPage 2016-04-04 08:40:49 -07:00