mirror of
https://we.phorge.it/source/phorge.git
synced 2025-02-10 05:48:30 +01:00
4fd4ec3d27
Summary: Ref T12616. Fixes T12153. Currently, when you hide inlines, they hide completely and turn into a little bubble on the previous line. Instead, collapse them to a single line one-by-one. Narrowly, this fixes T12153. In the future, I plan to make these changes so this feature makes more sense: - Introduce global "hide everything" states (T8909) so you can completely hide stuff if you want, and this represents more of a halfway state between "nuke it" and "view it". - Make the actual rendering better, so it says "epriestley: blah blah..." instead of just "..." -- and looks less dumb. The real goal here is to introduce `DiffInline` and continue moving stuff from the tangled jungle of a million top-level behaviors to sensible smooth statefulness. Test Plan: - Hid and revealed inlines in unified and two-up modes. - These look pretty junk for now: {F4948659} Reviewers: chad Reviewed By: chad Maniphest Tasks: T12616, T12153 Differential Revision: https://secure.phabricator.com/D17861
33 lines
698 B
PHP
33 lines
698 B
PHP
<?php
|
|
|
|
/**
|
|
* Render the "Undo" action to recover discarded inline comments.
|
|
*
|
|
* This extends @{class:PHUIDiffInlineCommentView} so it can use the same
|
|
* scaffolding code as other kinds of inline comments.
|
|
*/
|
|
final class PHUIDiffInlineCommentUndoView
|
|
extends PHUIDiffInlineCommentView {
|
|
|
|
public function isHideable() {
|
|
return false;
|
|
}
|
|
|
|
public function render() {
|
|
$link = javelin_tag(
|
|
'a',
|
|
array(
|
|
'href' => '#',
|
|
'sigil' => 'differential-inline-comment-undo',
|
|
),
|
|
pht('Undo'));
|
|
|
|
return phutil_tag(
|
|
'div',
|
|
array(
|
|
'class' => 'differential-inline-undo',
|
|
),
|
|
array(pht('Changes discarded. '), $link));
|
|
}
|
|
|
|
}
|