1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-27 16:00:59 +01:00
phorge-phorge/src/view/phui
epriestley d42d69aef6 Clean up some PHUI/PHUIX button behaviors
Summary:
Ref T12733. Some minor issues:

  - The `strlen(...)` test against `$this->text` fails if a caller does something like `setText(array(...))`. This is rare, but used in `DiffusionBrowseController`, from D15487.
  - Add PHUIX examples for icon-only buttons.
  - Remove unused `SIMPLE` constant now that no callsites remain.

Test Plan:
  - Viewed a directory in Diffusion's "Browse" view in a Git repository, no longer saw a warning / error log.
  - Viewed PHUIX Components UI examples.
  - Grepped for `::SIMPLE`.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12733

Differential Revision: https://secure.phabricator.com/D18065
2017-06-02 08:37:52 -07:00
..
__tests__ Ensure that PHUIInvisibleCharacterTestCase is compatible with PHP 5.3 2016-11-15 14:46:22 -08:00
calendar Fix errors found by PHPStan 2017-02-18 09:24:56 +00:00
PHUI.php Remove unused call to phui-text 2016-01-29 12:41:04 -08:00
PHUIActionPanelView.php Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
PHUIBadgeBoxView.php PHUIBadgeMiniView 2015-07-10 10:49:28 -07:00
PHUIBadgeMiniView.php Converting badge quality property from color to an integer representation for later sorting purposes 2016-03-30 17:28:34 -07:00
PHUIBadgeView.php Links on badge card should be accessible 2016-04-15 07:55:31 -07:00
PHUIBigInfoView.php Convert all calls to 'IconFont' to just 'Icon' 2016-01-27 20:59:27 -08:00
PHUIBoxView.php Add basic grey and blue styles for PHUIBoxView 2016-01-21 07:14:39 -08:00
PHUIButtonBarView.php Move simple buttons, bar to own CSS file 2017-06-01 16:52:00 -07:00
PHUIButtonView.php Clean up some PHUI/PHUIX button behaviors 2017-06-02 08:37:52 -07:00
PHUICMSView.php Rough in Guides Application 2016-08-17 10:14:05 -07:00
PHUICrumbsView.php Add fullscreen mode to Workboards 2016-02-10 15:31:02 +00:00
PHUICrumbView.php Fourth fix for the magical world of crumbs and text-overflow 2017-03-09 07:23:41 -08:00
PHUIDocumentSummaryView.php Add a Read More link to PHUIDocumentSummaryView 2015-12-19 12:49:23 -08:00
PHUIDocumentViewPro.php Make "simple" a "button type", not a "color" 2017-05-30 17:59:37 -07:00
PHUIFeedStoryView.php Strip timestamps from popup notification bubbles 2016-07-08 07:46:09 -07:00
PHUIHeaderView.php Search and Replace calls to setShade 2017-05-22 18:59:53 +00:00
PHUIHeadThingView.php Update Diffusion UI 2016-03-17 12:05:14 -07:00
PHUIHovercardView.php Add an Owners Package hovercard 2017-04-26 08:45:39 -07:00
PHUIIconCircleView.php Try layering state icons on PHUICircleIconView 2017-05-26 13:55:42 -07:00
PHUIIconView.php Add FontAwesome 4.7.0 2017-02-01 16:34:48 -08:00
PHUIImageMaskView.php Fix AphrontTagView visibility 2015-01-14 06:54:39 +11:00
PHUIInfoPanelView.php Minor linter fixes 2014-12-30 02:48:03 -08:00
PHUIInvisibleCharacterView.php Added initial class for displaying invisible chars 2016-09-12 21:57:01 -04:00
PHUIListItemView.php Use PHUIListItemView in ConpherenceThreadList 2017-04-17 11:21:49 -07:00
PHUIListView.php Improve handle loading semantics for tokenizers 2015-04-02 13:42:01 -07:00
PHUIObjectBoxView.php Attach Diffusion Pagers to their ObjectBoxView 2017-04-21 11:22:19 -07:00
PHUIObjectItemListView.php Reorganize phui-object-item CSS, add drag ui 2016-12-14 11:53:17 -08:00
PHUIObjectItemView.php Move setLaunchButton to setSideColumn for ObjectItem 2017-05-25 15:31:19 -07:00
PHUIPagerView.php Fix pagination of fulltext search results 2017-04-12 17:57:46 -07:00
PHUIPinboardItemView.php Convert all calls to 'IconFont' to just 'Icon' 2016-01-27 20:59:27 -08:00
PHUIPinboardView.php [Redesign] Center Pinboard Items 2015-05-31 14:28:16 -07:00
PHUIPropertyGroupView.php PHUIPropertyListView 2013-10-11 07:53:56 -07:00
PHUIPropertyListView.php Disambiguate isEmpty() 2016-01-31 15:20:04 -08:00
PHUIRemarkupPreviewPanel.php Use PHUIRemarkupPreviewView in Phame 2015-11-23 10:36:02 -08:00
PHUISegmentBarSegmentView.php Add a basic progress bar for milestones 2016-02-08 18:50:22 -08:00
PHUISegmentBarView.php First cut of progress bars (PHUISegmentBarView) 2016-02-08 15:28:09 -08:00
PHUIStatusItemView.php Update Calendar for PHUITwoColumnView 2016-03-02 18:12:42 -08:00
PHUIStatusListView.php Fix AphrontTagView visibility 2015-01-14 06:54:39 +11:00
PHUITabGroupView.php Remove old ObjectBox tab cruft 2016-06-30 18:50:25 -07:00
PHUITabView.php Build that thing someone posted a screenshot of on Facebook 2016-07-01 04:36:24 -07:00
PHUITagView.php Search and Replace calls to setShade 2017-05-22 18:59:53 +00:00
PHUITimelineEventView.php Add Pinboard Items to Timeline 2017-05-18 10:34:57 -07:00
PHUITimelineView.php Add Badges to UserCache 2017-03-17 10:38:17 -07:00
PHUITwoColumnView.php Clean up recurring event information on Calendar events 2016-07-28 10:59:28 -07:00
PHUIWorkboardView.php Only prevent drag-scroll in the Y direction on workboards 2016-02-08 10:05:39 -08:00
PHUIWorkpanelView.php Expand scope of addActionItem in PHUIHeaderView 2016-03-04 18:35:05 -08:00