1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 01:32:42 +01:00
phorge-phorge/src/applications/policy
epriestley d6247ffca5 Add support for "Extended Policies"
Summary:
Ref T7703. See that task and inline for a bunch of discussion.

Briefly, when we run implicit policy rules ("to see a revision, you must also be able to see its repository") at query time, they don't apply to other viewers we might check later.

We do this very rarely, but when we do we're often doing it for a bunch of different viewers (for example, in Herald) so I don't want to just reload the object a million times.

Test Plan:
  - Added and executed unit tests.
  - Wrote a "flag everything" Herald rule, as in the original report in T7703, and no longer got "Unknown Object" flags on revisions.
  - Rigged up a lot of cases in the web UI and couldn't find any inconsistencies, although this case is normally very hard to hit.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7703

Differential Revision: https://secure.phabricator.com/D13104
2015-06-03 18:59:27 -07:00
..
__tests__ Add support for "Extended Policies" 2015-06-03 18:59:27 -07:00
application Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
capability phtize all the things 2015-05-22 21:16:39 +10:00
config phtize all the things 2015-05-22 21:16:39 +10:00
constants Use __CLASS__ instead of hard-coding class names 2015-05-14 07:21:13 +10:00
controller phtize all the things 2015-05-22 21:16:39 +10:00
exception Allow applications to define new policy capabilities 2013-10-07 13:28:58 -07:00
filter Add support for "Extended Policies" 2015-06-03 18:59:27 -07:00
interface Add support for "Extended Policies" 2015-06-03 18:59:27 -07:00
management phtize all the things 2015-05-22 21:16:39 +10:00
phid Simplify the implementation of PhabricatorPHIDType subclasses 2014-07-22 00:38:23 +10:00
query phtize all the things 2015-05-22 21:16:39 +10:00
rule Make browse action available for dynamic/JS-driven tokenizers 2015-04-17 11:06:58 -07:00
storage phtize all the things 2015-05-22 21:16:39 +10:00