mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-13 10:22:42 +01:00
d84c0a5be5
Summary:
- We currently run ##parseValueFromCommitMessage()## on all fields present in
the message, but not ##validateField()##.
- This detects value errors (e.g., an invalid reviewer) but not higher-level
errors (e.g., a missing field).
- This can break the stacked-commits Git mutable history workflow by
recognizing too many commit messages as valid ("multiple valid commit messages,
this is ambiguous").
- This also gives you some errors ("Missing test plan") too late in "arc diff
--create" (after the diff has been built).
Test Plan:
- Grepped for validateField() calls, removed a couple of calls that had the
same implementation as the base class.
- Grepped for other calls to this to make sure I'm not stumbling into
unintended side effects, but it only runs from the diff workflow.
- Ran "arc diff --create" with an invalid test plan, got a good error early in
the process.
- Ran "arc diff master" with stacked local commits, got a correct selection of
the intended message.
Reviewers: cpiro, btrahan, jungejason
Reviewed By: cpiro
CC: aran, cpiro
Differential Revision: https://secure.phabricator.com/D1373
|
||
|---|---|---|
| .. | ||
| audit | ||
| auth | ||
| base | ||
| calendar | ||
| conduit | ||
| countdown | ||
| daemon | ||
| differential | ||
| diffusion | ||
| directory | ||
| draft/storage | ||
| feed | ||
| files | ||
| help/controller | ||
| herald | ||
| maniphest | ||
| markup | ||
| metamta | ||
| owners | ||
| paste | ||
| people | ||
| phid | ||
| phriction | ||
| project | ||
| repository | ||
| search | ||
| slowvote | ||
| status/base | ||
| typeahead/controller | ||
| uiexample | ||
| xhpastview | ||
| xhprof | ||