revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-02 11:42:42 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/differential/conduit
History
epriestley 5741514aeb When a client submits an overlong "sourcePath", truncate it and continue 
Summary:
Ref T13385. Currently, if you run `arc diff` in a CWD with more than 255 characters, the workflow fatals against the length of the `sourcePath` database column.

In the long term, removing this property is likely desirable.

For now, truncate long values and continue. This only meaningfully impacts relatively obscure interactive SVN workflows negatively, and even there, "some arc commands are glitchy in very long working directories in SVN" is still better than "arc diff fatals".

Test Plan:
  - Modified `arc` to submit very long source paths.
  - Ran `arc diff`.
    - Before: Fatal when inserting >255 characters into `sourcePath`.
    - After: Path truncated at 255 bytes.

Maniphest Tasks: T13385

Differential Revision: https://secure.phabricator.com/D20727
2019-08-21 19:28:18 -07:00
..
DifferentialCloseConduitAPIMethod.php Modularize remaining TYPE_ACTION transactions in Differential, reducing calls to ArcanistDifferentialRevisionStatus 2017-08-11 17:20:55 -07:00
DifferentialConduitAPIMethod.php Mostly modularize the Differential "update" transaction 2018-03-06 09:10:32 -08:00
DifferentialCreateCommentConduitAPIMethod.php Remove legacy transaction editor "getDisableEmail()" method 2018-01-19 13:23:06 -08:00
DifferentialCreateDiffConduitAPIMethod.php When a client submits an overlong "sourcePath", truncate it and continue 2019-08-21 19:28:18 -07:00
DifferentialCreateInlineConduitAPIMethod.php phtize all the things 2015-05-22 21:16:39 +10:00
DifferentialCreateRawDiffConduitAPIMethod.php Remove "Large Changes" documentation and make some minor behavioral improvements 2018-04-05 06:40:46 -07:00
DifferentialCreateRevisionConduitAPIMethod.php Rename "getReviewerStatus()" to "getReviewers()" 2017-03-20 17:11:40 -07:00
DifferentialDiffSearchConduitAPIMethod.php Provide "differential.diff.search" 2017-10-30 15:06:10 -07:00
DifferentialGetAllDiffsConduitAPIMethod.php phtize all the things 2015-05-22 21:16:39 +10:00
DifferentialGetCommitMessageConduitAPIMethod.php Rename "needReviewerStatus()" into "needReviewers()" 2017-03-20 16:46:16 -07:00
DifferentialGetCommitPathsConduitAPIMethod.php phtize all the things 2015-05-22 21:16:39 +10:00
DifferentialGetDiffConduitAPIMethod.php phtize all the things 2015-05-22 21:16:39 +10:00
DifferentialGetRawDiffConduitAPIMethod.php Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
DifferentialGetRevisionCommentsConduitAPIMethod.php phtize all the things 2015-05-22 21:16:39 +10:00
DifferentialGetRevisionConduitAPIMethod.php Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table 2019-04-24 05:54:38 -07:00
DifferentialParseCommitMessageConduitAPIMethod.php Return transactions from "differential.parsecommitmessage" 2017-10-30 15:15:42 -07:00
DifferentialQueryConduitAPIMethod.php Make legacy revision statuses from "differential.query" have type "string" again 2017-08-29 13:05:02 -07:00
DifferentialQueryDiffsConduitAPIMethod.php Provide "differential.diff.search" 2017-10-30 15:06:10 -07:00
DifferentialRevisionEditConduitAPIMethod.php Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine 2016-12-16 10:08:49 -08:00
DifferentialRevisionSearchConduitAPIMethod.php Implement basic differential.revision.search 2016-06-09 09:06:58 -07:00
DifferentialSetDiffPropertyConduitAPIMethod.php Remove some obsolete lint and unit support 2015-08-10 14:16:25 -07:00
DifferentialUpdateRevisionConduitAPIMethod.php Reduce STATUS_CLOSED (now internally "Published") revision status callsites 2017-08-09 11:05:42 -07:00