mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-02 19:52:44 +01:00
0ceab7d36f
Summary: Ref T10967. Improves some method names: - `Revision->getReviewerStatus()` -> `Revision->getReviewers()` - `Revision->attachReviewerStatus()` -> `Revision->attachReviewers()` - `Reviewer->getStatus()` -> `Reviewer->getReviewerStatus()` (this is mostly to make this more greppable) Test Plan: - bunch o' `grep` - Browsed around. - If I missed anything, it should fatal in an obvious way. We have a lot of other `getStatus()` calls and it's hard to be sure I got them all. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10967 Differential Revision: https://secure.phabricator.com/D17522
73 lines
1.8 KiB
PHP
73 lines
1.8 KiB
PHP
<?php
|
|
|
|
final class DifferentialCreateRevisionConduitAPIMethod
|
|
extends DifferentialConduitAPIMethod {
|
|
|
|
public function getAPIMethodName() {
|
|
return 'differential.createrevision';
|
|
}
|
|
|
|
public function getMethodDescription() {
|
|
return pht('Create a new Differential revision.');
|
|
}
|
|
|
|
public function getMethodStatus() {
|
|
return self::METHOD_STATUS_FROZEN;
|
|
}
|
|
|
|
public function getMethodStatusDescription() {
|
|
return pht(
|
|
'This method is frozen and will eventually be deprecated. New code '.
|
|
'should use "differential.revision.edit" instead.');
|
|
}
|
|
|
|
protected function defineParamTypes() {
|
|
return array(
|
|
// TODO: Arcanist passes this; prevent fatals after D4191 until Conduit
|
|
// version 7 or newer.
|
|
'user' => 'ignored',
|
|
'diffid' => 'required diffid',
|
|
'fields' => 'required dict',
|
|
);
|
|
}
|
|
|
|
protected function defineReturnType() {
|
|
return 'nonempty dict';
|
|
}
|
|
|
|
protected function defineErrorTypes() {
|
|
return array(
|
|
'ERR_BAD_DIFF' => pht('Bad diff ID.'),
|
|
);
|
|
}
|
|
|
|
protected function execute(ConduitAPIRequest $request) {
|
|
$viewer = $request->getUser();
|
|
|
|
$diff = id(new DifferentialDiffQuery())
|
|
->setViewer($viewer)
|
|
->withIDs(array($request->getValue('diffid')))
|
|
->executeOne();
|
|
if (!$diff) {
|
|
throw new ConduitException('ERR_BAD_DIFF');
|
|
}
|
|
|
|
$revision = DifferentialRevision::initializeNewRevision($viewer);
|
|
$revision->attachReviewers(array());
|
|
|
|
$result = $this->applyFieldEdit(
|
|
$request,
|
|
$revision,
|
|
$diff,
|
|
$request->getValue('fields', array()),
|
|
$message = null);
|
|
|
|
$revision_id = $result['object']['id'];
|
|
|
|
return array(
|
|
'revisionid' => $revision_id,
|
|
'uri' => PhabricatorEnv::getURI('/D'.$revision_id),
|
|
);
|
|
}
|
|
|
|
}
|