2011-02-06 22:49:23 +01:00
|
|
|
<?php
|
|
|
|
|
Rename Conduit classes
Summary: Ref T5655. Rename Conduit classes and provide a `getAPIMethodName` method to declare the API method.
Test Plan:
```
> echo '{}' | arc --conduit-uri='http://phabricator.joshuaspence.com' call-conduit user.whoami
Waiting for JSON parameters on stdin...
{"error":null,"errorMessage":null,"response":{"phid":"PHID-USER-lioqffnwn6y475mu5ndb","userName":"josh","realName":"Joshua Spence","image":"http:\/\/phabricator.joshuaspence.com\/res\/1404425321T\/phabricator\/3eb28cd9\/rsrc\/image\/avatar.png","uri":"http:\/\/phabricator.joshuaspence.com\/p\/josh\/","roles":["admin","verified","approved","activated"]}}
```
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: epriestley, Korvin, hach-que
Maniphest Tasks: T5655
Differential Revision: https://secure.phabricator.com/D9991
2014-07-25 02:54:15 +02:00
|
|
|
final class DifferentialCreateRevisionConduitAPIMethod
|
|
|
|
extends DifferentialConduitAPIMethod {
|
|
|
|
|
|
|
|
public function getAPIMethodName() {
|
|
|
|
return 'differential.createrevision';
|
|
|
|
}
|
2011-02-06 22:49:23 +01:00
|
|
|
|
|
|
|
public function getMethodDescription() {
|
2014-06-09 20:36:49 +02:00
|
|
|
return pht('Create a new Differential revision.');
|
2011-02-06 22:49:23 +01:00
|
|
|
}
|
|
|
|
|
2017-01-08 21:54:39 +01:00
|
|
|
public function getMethodStatus() {
|
|
|
|
return self::METHOD_STATUS_FROZEN;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getMethodStatusDescription() {
|
|
|
|
return pht(
|
|
|
|
'This method is frozen and will eventually be deprecated. New code '.
|
|
|
|
'should use "differential.revision.edit" instead.');
|
|
|
|
}
|
|
|
|
|
2015-04-13 00:59:07 +02:00
|
|
|
protected function defineParamTypes() {
|
2011-02-06 22:49:23 +01:00
|
|
|
return array(
|
2012-12-17 23:45:11 +01:00
|
|
|
// TODO: Arcanist passes this; prevent fatals after D4191 until Conduit
|
|
|
|
// version 7 or newer.
|
|
|
|
'user' => 'ignored',
|
2011-02-06 22:49:23 +01:00
|
|
|
'diffid' => 'required diffid',
|
|
|
|
'fields' => 'required dict',
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2015-04-13 00:59:07 +02:00
|
|
|
protected function defineReturnType() {
|
2011-02-06 22:49:23 +01:00
|
|
|
return 'nonempty dict';
|
|
|
|
}
|
|
|
|
|
2015-04-13 00:59:07 +02:00
|
|
|
protected function defineErrorTypes() {
|
2011-02-06 22:49:23 +01:00
|
|
|
return array(
|
2015-05-22 09:27:56 +02:00
|
|
|
'ERR_BAD_DIFF' => pht('Bad diff ID.'),
|
2011-02-06 22:49:23 +01:00
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
protected function execute(ConduitAPIRequest $request) {
|
2014-03-08 20:21:38 +01:00
|
|
|
$viewer = $request->getUser();
|
2011-02-06 22:49:23 +01:00
|
|
|
|
2013-07-01 21:38:42 +02:00
|
|
|
$diff = id(new DifferentialDiffQuery())
|
2014-03-08 20:21:38 +01:00
|
|
|
->setViewer($viewer)
|
2013-07-01 21:38:42 +02:00
|
|
|
->withIDs(array($request->getValue('diffid')))
|
|
|
|
->executeOne();
|
2011-02-06 22:49:23 +01:00
|
|
|
if (!$diff) {
|
|
|
|
throw new ConduitException('ERR_BAD_DIFF');
|
|
|
|
}
|
|
|
|
|
2014-03-08 20:21:38 +01:00
|
|
|
$revision = DifferentialRevision::initializeNewRevision($viewer);
|
2017-03-20 23:04:23 +01:00
|
|
|
$revision->attachReviewers(array());
|
2014-03-08 20:21:38 +01:00
|
|
|
|
2016-12-16 13:45:55 +01:00
|
|
|
$result = $this->applyFieldEdit(
|
2014-03-08 20:21:38 +01:00
|
|
|
$request,
|
|
|
|
$revision,
|
2011-02-06 22:49:23 +01:00
|
|
|
$diff,
|
2014-03-08 20:21:38 +01:00
|
|
|
$request->getValue('fields', array()),
|
|
|
|
$message = null);
|
2011-02-06 22:49:23 +01:00
|
|
|
|
2016-12-16 13:45:55 +01:00
|
|
|
$revision_id = $result['object']['id'];
|
|
|
|
|
2011-02-06 22:49:23 +01:00
|
|
|
return array(
|
2016-12-16 13:45:55 +01:00
|
|
|
'revisionid' => $revision_id,
|
|
|
|
'uri' => PhabricatorEnv::getURI('/D'.$revision_id),
|
2011-02-06 22:49:23 +01:00
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|