1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 03:12:41 +01:00
phorge-phorge/src/applications/harbormaster
Bob Trahan 5a9df1a225 Policy - filter app engines where the user can't see the application from panel editing
Summary: Fixes T7118. This does the basic "filter the list" thing, though it ends up being a little manual since I guess this hasn't come up before? There is also potential weird behavior if the user was using an app and lost access to it - they will have nothing selected on edit - but I think this is actually correct behavior in this circumstance.

Test Plan:
used a user who couldn't get access to the "quick create" apps and noted that the dropdown list on dashboard panel create was missing the expected engines

ran `arc unit --everything` to verify abstract method implemented everywhere

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7118

Differential Revision: https://secure.phabricator.com/D11687
2015-02-04 15:47:48 -08:00
..
application Remove getIconName from all applications 2015-01-30 12:11:21 -08:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
conduit Rename Conduit classes 2014-07-25 10:54:15 +10:00
config Use icons with Config Options page 2015-02-02 10:17:25 -08:00
controller PHUIErrorView 2015-02-01 20:14:56 -08:00
customfield Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
editor Minor formatting changes 2014-10-08 08:39:49 +11:00
engine Minor formatting changes 2014-10-08 08:39:49 +11:00
event Implement showing buildable status in Diffusion 2014-06-14 02:28:00 +10:00
exception Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
interface Move build variables into HarbormasterBuildableInterface 2014-06-20 12:58:23 +10:00
management Fix visibility of PhutilArgumentWorkflow::didConstruct methods 2015-01-16 07:42:07 +11:00
phid Implement build simulation; convert Harbormaster to be purely dependency based 2014-07-31 11:39:49 +10:00
query Policy - filter app engines where the user can't see the application from panel editing 2015-02-04 15:47:48 -08:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
step Use new FutureIterator instead of Futures 2014-12-30 23:13:38 +11:00
storage Use %B for Harbormaster build log updates as well 2015-02-03 22:59:29 +00:00
typeahead Implement build simulation; convert Harbormaster to be purely dependency based 2014-07-31 11:39:49 +10:00
view Minor formatting changes 2014-10-08 08:39:49 +11:00
worker Fix visibility of the PhabricatorWorker::doWork() methods 2015-01-16 06:58:50 +11:00