1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications/differential
Bob Trahan dcd7a316d2 Differential - add DifferentialDraft to track whether revisions have draft feedback or not
Summary: ...do it somewhat generically, so we could fairly easily add this to other applications. Fixes T3496. I got a wee bit lazy and decided not to migrate existing drafts. My excuses aside from laziness are doing it this way will let us see if anyone complains, we can always do a migration later if people do complain, and there's likely to be a lot of garbage data for older / bigger installs, and the migration didn't seem worth itgiven it would also likely be expensive in these cases.

Test Plan: made a draft inline comment on DX and observed DX had a note icon on Differential home page. made a draft comment on DX and observed DX had a note icon on Differential home page. deleted a draft inline comment and noted icon disappeared from Differential homepage. Submitted a draft comment + inline comment and noted icon disappeared.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T3496

Differential Revision: https://secure.phabricator.com/D8275
2014-02-18 16:25:16 -08:00
..
__tests__ Require a viewer for Remarkup rendering 2013-03-04 12:33:05 -08:00
application Land Revision button for hosted git repos 2013-11-05 13:00:13 -08:00
capability Allow "Default View" policies to be set to Public 2013-10-09 15:06:18 -07:00
conduit Migrate Differential comments to ApplicationTransactions 2014-02-12 14:34:48 -08:00
config Add a config flag to treat "Accepted" revisions as "Closed" 2013-11-25 17:40:01 -08:00
constants Fix double-rendering of inline comments in mail 2014-02-13 15:00:29 -08:00
controller Differential - add DifferentialDraft to track whether revisions have draft feedback or not 2014-02-18 16:25:16 -08:00
doorkeeper Normalize the definition of "closed" revision statuses 2013-11-25 17:39:24 -08:00
editor Fix inline comment links for non-visible comments 2014-02-13 16:52:48 -08:00
event Make event-triggered actions more aware of application access 2013-10-21 17:00:50 -07:00
exception Delete license headers from files 2012-11-05 11:16:51 -08:00
field Move many task status hardcodes into ManiphestTaskStatus 2014-02-17 15:59:31 -08:00
garbagecollector Complete modularization of the GC daemon 2014-01-15 10:02:31 -08:00
landing Add Disabled mode to landing revision ui 2014-01-30 09:07:50 -08:00
lipsum Add a "default view" policy to Differential 2013-10-09 13:58:00 -07:00
mail Fix double-rendering of inline comments in mail 2014-02-13 15:00:29 -08:00
parser Make most file reads policy-aware 2013-09-30 09:38:13 -07:00
phid Remove many redundant implementations of canLoadNamedObject() 2013-12-18 12:00:01 -08:00
query Differential - add DifferentialDraft to track whether revisions have draft feedback or not 2014-02-18 16:25:16 -08:00
remarkup Require a viewer for Remarkup rendering 2013-03-04 12:33:05 -08:00
render Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00
search Migrate Differential comments to ApplicationTransactions 2014-02-12 14:34:48 -08:00
storage Differential - add DifferentialDraft to track whether revisions have draft feedback or not 2014-02-18 16:25:16 -08:00
view Render Differential previews through ApplicationTransactions 2014-02-14 13:16:58 -08:00
DifferentialGetWorkingCopy.php Semi-fix git cloning for non-bare repos for landing 2013-12-30 15:22:32 -08:00
DifferentialTasksAttacher.php Delete license headers from files 2012-11-05 11:16:51 -08:00