1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 00:02:41 +01:00
phorge-phorge/src/applications/differential
Aviv Eyal dcf909ba56 Land to GitHub + support stuff
Summary:
A usable, Land to GitHub flow.

Still to do:
- Refactor all git/hg stratagies to a sane structure.
- Make the dialogs Workflow + explain why it's disabled.
- Show button and request Link Account if GH is enabled, but user is not linked.
- After refreshing token, user ends up in the settings stage.

Hacked something in LandController to be able to show an arbitrary dialog from a strategy.
It's not very nice, but I want to make some more refactoring to the controller/strategy/ies anyway.

Also made PhabricatorRepository::getRemoteURIObject() public, because it was very useful in getting
the domain and path for the repo.

Test Plan:
Went through these flows:
- load revision in hosted, github-backed, non-github backed repos to see button as needed.
- hit land with weak token - sent to refresh it with the extra scope.
- Land to repo I'm not allowed - got proper error message.
- Successfully landed; Failed to apply patch.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T182

Differential Revision: https://secure.phabricator.com/D7555
2013-11-13 17:25:24 -08:00
..
__tests__ Require a viewer for Remarkup rendering 2013-03-04 12:33:05 -08:00
application Land Revision button for hosted git repos 2013-11-05 13:00:13 -08:00
capability Allow "Default View" policies to be set to Public 2013-10-09 15:06:18 -07:00
conduit Remove differential.anonymous-access 2013-11-11 16:05:19 -08:00
config Remove differential.anonymous-access 2013-11-11 16:05:19 -08:00
constants Provide an "Add blocking reviewer..." Herald action 2013-10-06 17:09:24 -07:00
controller Land to GitHub + support stuff 2013-11-13 17:25:24 -08:00
doorkeeper Improve voicing in text published to JIRA issues 2013-09-10 15:22:24 -07:00
editor Use herald to trigger builds of revisions and commits. 2013-11-08 16:58:39 -08:00
event Make event-triggered actions more aware of application access 2013-10-21 17:00:50 -07:00
exception Delete license headers from files 2012-11-05 11:16:51 -08:00
field Always pass handles to tokenizers, not <phid -> name> maps 2013-10-07 12:51:24 -07:00
landing Land to GitHub + support stuff 2013-11-13 17:25:24 -08:00
lipsum Add a "default view" policy to Differential 2013-10-09 13:58:00 -07:00
mail Fix "Manage herald rules" link by removing it 2013-10-21 16:58:56 -07:00
parser Make most file reads policy-aware 2013-09-30 09:38:13 -07:00
phid Assign PHIDs to all diffs 2013-11-06 13:59:06 -08:00
query Assign PHIDs to all diffs 2013-11-06 13:59:06 -08:00
remarkup Require a viewer for Remarkup rendering 2013-03-04 12:33:05 -08:00
render Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00
search Remove legacy "touched" table and indexing 2013-09-12 13:04:09 -07:00
storage Assign PHIDs to all diffs 2013-11-06 13:59:06 -08:00
view Replace some hsprintf() by phutil_tag() 2013-11-11 09:23:23 -08:00
DifferentialGetWorkingCopy.php Add support for landing to hosted Mercurial repos. 2013-11-08 11:39:32 -08:00
DifferentialTasksAttacher.php Delete license headers from files 2012-11-05 11:16:51 -08:00