1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 08:42:41 +01:00
phorge-phorge/webroot/rsrc
epriestley dde63af1cc Fix a JS console warning when hovering over replies to ghosts on lines which no longer exist
Summary:
Fixes T11662. In the very obscure situation described in that task, quiet a JS console warning.

The actual edit operation appears to work correctly after changes elsewhere.

There aren't really any legitimate lines for us to highlight in this case so I'm just giving up rather than trying to do something approximate.

Test Plan:
  - Wrote `long.txt`.
  - Created revision.
  - Added an inline near the bottom.
  - Removed most of `long.txt`.
  - Updated revsion.
  - Replied to the ghost inline.
  - Edited the reply to the ghost inline, worked.
  - Hovered the reply to the ghost inline: no line highlight, but no errors.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11662

Differential Revision: https://secure.phabricator.com/D17930
2017-05-17 08:55:10 -07:00
..
audio/basic Add a few more sounds 2017-04-19 13:47:23 -07:00
css Move "hover over an inline to see the affected lines" code to the new class tree 2017-05-16 17:37:38 -07:00
externals Move the "select a line range" inline code to DiffInline 2017-05-17 08:41:26 -07:00
favicons JX.Favicon for Conpherence 2016-10-20 12:17:50 -07:00
image Add some higher resolution default user images 2017-02-26 09:56:21 -08:00
js Fix a JS console warning when hovering over replies to ghosts on lines which no longer exist 2017-05-17 08:55:10 -07:00