1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
phorge-phorge/webroot/rsrc/js
epriestley dde63af1cc Fix a JS console warning when hovering over replies to ghosts on lines which no longer exist
Summary:
Fixes T11662. In the very obscure situation described in that task, quiet a JS console warning.

The actual edit operation appears to work correctly after changes elsewhere.

There aren't really any legitimate lines for us to highlight in this case so I'm just giving up rather than trying to do something approximate.

Test Plan:
  - Wrote `long.txt`.
  - Created revision.
  - Added an inline near the bottom.
  - Removed most of `long.txt`.
  - Updated revsion.
  - Replied to the ghost inline.
  - Edited the reply to the ghost inline, worked.
  - Hovered the reply to the ghost inline: no line highlight, but no errors.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11662

Differential Revision: https://secure.phabricator.com/D17930
2017-05-17 08:55:10 -07:00
..
application Fix a JS console warning when hovering over replies to ghosts on lines which no longer exist 2017-05-17 08:55:10 -07:00
core When the Differential filetree is toggled, resize the keyboard reticle properly 2017-05-16 08:22:07 -07:00
phui Attempt to make dropdown item actions more consistent 2017-01-18 13:14:54 -08:00
phuix Fix autocomplete/send-on-enter interactions 2017-04-26 08:48:25 -07:00