1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-02 19:52:44 +01:00
phorge-phorge/src/applications/differential
epriestley e57dbcda33 Hide "abraham landed Dxyz irresponsibly" stories from feed
Summary:
Ref T13099. Ref T12787. See PHI417. Differential has new "irresponsible" warnings in the timeline somewhat recently, but these publish feed stories that don't link to the revision or have other relevant details, so they're confusing on the balance.

These have a high strength so they render on top, but we actually just want to hide them from the feed and let "abraham closed Dxyz by committing rXzzz." be the primary story.

Modularize things more so that we can get this behavior. Also, respect `shouldHideForFeed()` at display time, not just publishing time.

Test Plan: Used `bin/differential attach-commit` on a non-accepted revision to "irresponsibly land" a revision. Verified that feed story now shows "closed by commit" instead of "closed irresponsibly".

Maniphest Tasks: T13099, T12787

Differential Revision: https://secure.phabricator.com/D19179
2018-03-06 17:48:03 -08:00
..
__tests__ phtize all the things 2015-05-22 21:16:39 +10:00
application Make Facts more modern, DRY, and dimensional 2018-02-19 12:05:19 -08:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
command Define Differential email action in terms of EditEngine 2017-01-02 13:25:45 -08:00
conduit Mostly modularize the Differential "update" transaction 2018-03-06 09:10:32 -08:00
config Add yaml files to differential.whitespace-matters 2017-11-15 11:57:11 -08:00
constants Include "Draft" revisions in Differential legacy status queries 2017-11-07 15:35:33 -08:00
controller Show lint messages in deleted files on the left-hand side of the change 2018-03-04 09:14:10 -08:00
customfield Make Harbormaster buildable status more of a nice flexible map and less of a bunch of switch statements 2018-02-12 12:18:06 -08:00
doorkeeper Reduce callsites to "ArcanistDifferentialRevisionStatus" in Phabricator 2017-08-09 11:04:52 -07:00
edge Provide revision parent/child edges in edge.search, and more information in differential.revision.search 2017-11-07 15:34:31 -08:00
editor Mostly modularize the Differential "update" transaction 2018-03-06 09:10:32 -08:00
engine Return commit information for Revision "close" and "update" transactions over the Conduit API 2018-03-06 09:12:59 -08:00
engineextension Fix a mail stamp issue with blocking reviewers 2018-02-13 17:56:21 -08:00
exception Remove an unused class 2015-01-03 09:07:32 +11:00
field Move misplaced validation for ambiguous fields in "Test Plan" to the right place 2017-06-30 06:36:05 -07:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
herald Don't allow Herald Diff rules to "Call Webhooks" 2018-02-12 17:52:05 -08:00
lipsum Mostly modularize the Differential "update" transaction 2018-03-06 09:10:32 -08:00
mail Rename "needReviewerStatus()" into "needReviewers()" 2017-03-20 16:46:16 -07:00
management Completely remove the legacy hunk table 2018-02-10 16:12:50 -08:00
parser Completely remove the legacy hunk table 2018-02-10 16:12:50 -08:00
phid Make all revision status readers explicitly read modern or legacy status 2017-08-11 17:22:22 -07:00
query Completely remove the legacy hunk table 2018-02-10 16:12:50 -08:00
relationships Convert all standard relationship-editing actions to modern Relationships code 2016-06-29 11:24:52 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
render Add aural "+" and "-" hints to unified diffs for users who use screenreaders 2017-10-20 11:09:46 -07:00
search Reduce the amount of boilerplate that implementing FerretInterface requires 2017-09-07 13:23:31 -07:00
storage Mostly modularize the Differential "update" transaction 2018-03-06 09:10:32 -08:00
typeahead Fix spelling 2017-10-09 10:48:04 -07:00
view Make the filetree view width sticky across show/hide and reload 2018-02-22 13:47:41 -08:00
xaction Hide "abraham landed Dxyz irresponsibly" stories from feed 2018-03-06 17:48:03 -08:00
DifferentialGetWorkingCopy.php Extend from Phobject 2015-06-15 18:02:27 +10:00