1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 23:32:40 +01:00
phorge-phorge/src/applications/audit
epriestley e66a03eaa3 In Audit list and Owners list, show overall commit audit status instead of semi-viewer status
Summary:
Fixes T9482. Historically, Audit was somewhat confused about whether queries and views should act on the viewer's status or the object's status.

This realigns Audit to work like Differential: we show overall status for the commit, just like we show overall status for revisions. This better aligns with expectation and isn't weird/confusing, and bucketing should handle all the "what do //I// need to do" stuff now (or, at least, seems to have in Differential).

This is also how every other type of object works in every other application, AFAIK (all of them show object status, not viewer's-relationship-to-the-object status).

Test Plan:
  - Viewed commit lists in Owners and Audit.
  - Saw commit overall statuses, not my personal status.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9482

Differential Revision: https://secure.phabricator.com/D17195
2017-01-12 13:41:47 -08:00
..
application Provide bucketing for commits in Audit 2017-01-12 12:04:05 -08:00
conduit Provide bucketing for commits in Audit 2017-01-12 12:04:05 -08:00
constants Provide bucketing for commits in Audit 2017-01-12 12:04:05 -08:00
controller Merge "Audit" more completely into "Diffusion" 2017-01-11 16:28:42 -08:00
editor Merge "Audit" more completely into "Diffusion" 2017-01-11 16:28:42 -08:00
mail Merge "Audit" more completely into "Diffusion" 2017-01-11 16:28:42 -08:00
management Provide bucketing for commits in Audit 2017-01-12 12:04:05 -08:00
query In Audit list and Owners list, show overall commit audit status instead of semi-viewer status 2017-01-12 13:41:47 -08:00
storage Make new EditEngine Audit transactions apply old mail tags 2017-01-12 11:44:04 -08:00
view In Audit list and Owners list, show overall commit audit status instead of semi-viewer status 2017-01-12 13:41:47 -08:00