revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 17:22:42 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley e66a03eaa3 In Audit list and Owners list, show overall commit audit status instead of semi-viewer status 
Summary:
Fixes T9482. Historically, Audit was somewhat confused about whether queries and views should act on the viewer's status or the object's status.

This realigns Audit to work like Differential: we show overall status for the commit, just like we show overall status for revisions. This better aligns with expectation and isn't weird/confusing, and bucketing should handle all the "what do //I// need to do" stuff now (or, at least, seems to have in Differential).

This is also how every other type of object works in every other application, AFAIK (all of them show object status, not viewer's-relationship-to-the-object status).

Test Plan:
  - Viewed commit lists in Owners and Audit.
  - Saw commit overall statuses, not my personal status.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9482

Differential Revision: https://secure.phabricator.com/D17195
2017-01-12 13:41:47 -08:00
..
almanac Cache Almanac URIs for repositories 2016-12-06 09:14:45 -08:00
aphlict Discard stdout/stderr from the aphlict subprocess when running in daemon (normal) mode 2016-11-13 16:43:42 -08:00
arcanist/conduit Remove remaining arcanist project code 2015-07-08 19:37:28 +10:00
audit In Audit list and Owners list, show overall commit audit status instead of semi-viewer status 2017-01-12 13:41:47 -08:00
auth When rendering the "you were invited" header, query the inviting user with the omnipotent viewer 2016-12-09 08:35:34 -08:00
badges Remove some no-op "canUninstall()" Application methods 2016-12-05 11:02:25 -08:00
base Apply application visibility checks during normal object filtering 2017-01-02 10:00:00 -08:00
cache Introduce a serializing key-value cache proxy 2016-12-06 09:11:32 -08:00
calendar Fix an issue where setting a recurrence end date on a Calendar event without one could fatal 2017-01-06 16:36:09 -08:00
celerity Add basic diff coloring to CelerityDefaultProcessor 2017-01-10 17:54:24 -08:00
chatlog Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
conduit Mark "v3" API methods as stable; mark obsoleted methods as "Frozen" 2017-01-09 07:16:27 -08:00
config In the "Version Information" panel, try to include branchpoints 2016-12-23 11:42:20 -08:00
conpherence Use PhutilQueryCompiler in Phabricator fulltext search 2016-11-25 14:46:10 -08:00
console Remove "mysql.implementation" configuration 2016-11-22 04:15:34 -08:00
countdown Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
daemon Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
dashboard Add a Dashboard MenuItem 2016-12-16 13:33:03 -08:00
differential Render revision and audit state icons in Maniphest 2017-01-12 13:23:13 -08:00
diffusion Add diffusion.commit.search Conduit API method 2017-01-12 13:23:29 -08:00
diviner Remove unusual explicit calls to policy capability descriptions from Diviner 2016-12-14 11:23:05 -08:00
doorkeeper Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
draft/storage Clean up some log spam caused by races in VersionedDraft 2016-09-05 13:01:53 -07:00
drydock Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
fact Update Facts for newPage 2016-04-03 15:07:52 -07:00
favorites Make some defaults for Quick Create / Favorites 2017-01-11 08:46:33 -08:00
feed Prevent media from autoplaying when rendered as a feed story 2016-11-22 14:19:56 -08:00
files Add download link to embedded files 2017-01-03 10:50:26 -08:00
flag Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
fund Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
guides Add a bunch of Phacility-specific code to the upstream, thinly veiled as generic code 2016-11-15 09:11:22 -08:00
harbormaster Allow Harbormaster builds to publish to a different object 2017-01-04 13:46:39 -08:00
help Use "book" instead of "life ring" icon for global help menu 2016-10-28 14:33:18 -07:00
herald In Remarkup, render archived Herald rules with strikethrough for consistency 2016-12-08 12:37:54 -08:00
home Basic structure for MenuItem on Home 2017-01-11 12:44:56 -08:00
legalpad Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
lipsum Modularize content sources 2016-03-26 11:59:45 -07:00
macro Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
maniphest Render revision and audit state icons in Maniphest 2017-01-12 13:23:13 -08:00
meta Reorganize phui-object-item CSS, add drag ui 2016-12-14 11:53:17 -08:00
metamta Make Herald test workflow modular and more clear 2016-08-03 16:12:33 -07:00
multimeter Add a cluster.read-only option 2016-04-09 13:40:47 -07:00
notification Add an icon to aphlict connection status 2016-10-02 08:17:21 -07:00
nuance Remove some no-op "canUninstall()" Application methods 2016-12-05 11:02:25 -08:00
oauthserver Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
owners Provide bucketing for commits in Audit 2017-01-12 12:04:05 -08:00
packages Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
passphrase Make Passphrase "token" credentials accessible via the API 2016-11-15 09:12:35 -08:00
paste Mark "v3" API methods as stable; mark obsoleted methods as "Frozen" 2017-01-09 07:16:27 -08:00
people Merge "Audit" more completely into "Diffusion" 2017-01-11 16:28:42 -08:00
phame Allow custom Sites to have custom 404 controllers 2016-11-30 15:25:09 -08:00
phid Render revision and audit state icons in Maniphest 2017-01-12 13:23:13 -08:00
phlux Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
pholio Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
phortune When a Phortune subscription has a removed payment method, be more explicit about it 2016-11-23 14:07:40 -08:00
phpast Update phpast for new UI 2016-04-05 13:52:59 -07:00
phragment Remove some no-op "canUninstall()" Application methods 2016-12-05 11:02:25 -08:00
phrequent Redesign Config Application 2016-08-29 15:49:49 -07:00
phriction Fix Phriction document move on to existing document placeholder 2016-10-18 11:58:24 +00:00
phurl Don't send Phurl mail to the URL object itself 2016-11-15 09:12:15 -08:00
policy Provide bucketing for commits in Audit 2017-01-12 12:04:05 -08:00
ponder Make "Core Applications" more reasonable 2016-08-12 07:57:59 -07:00
project Use some more human-readable Conduit keys in updated API methods 2017-01-09 08:42:23 -08:00
releeph Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
remarkup/conduit
repository Add diffusion.commit.search Conduit API method 2017-01-12 13:23:29 -08:00
search Provide bucketing for commits in Audit 2017-01-12 12:04:05 -08:00
settings Correct "Manage Password" link in Quickling in Diffusion 2017-01-08 08:20:23 -08:00
slowvote Prepare for event imports in Calendar 2016-10-12 10:45:31 -07:00
spaces Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
subscriptions Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine 2016-12-16 10:08:49 -08:00
support/application
system Cache Almanac URIs for repositories 2016-12-06 09:14:45 -08:00
tokens Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
transactions Restore "[Action]" mail subject lines to Differential/Diffusion 2017-01-12 11:44:24 -08:00
typeahead Drive CLI-based revision edits through "differential.revision.edit" API + EditEngine 2016-12-16 10:08:49 -08:00
uiexample Add setBackground to PHUIIconView 2016-08-19 13:19:53 -07:00
xhprof Removing deprecated method calls 2016-08-23 03:26:34 -05:00