epriestley 138efb2b10 Recover from a race when importing external objects (like JIRA issues) for the first time ... Summary: Fixes T11604. If we send two requests to render a brand new tag at about the same time (say, 50ms apart) but JIRA takes more than 50ms to return from its API call, the two processes will race one another and try to save the same external object. If they do, have whichever one lost the race just load the object the other one created. Apply this to other bridges, too. Test Plan: - Created a new task in JIRA. - Referenced it for the first time in Differential, in a comment. - This causes two tag renders to fire. This //might// be a bug but I spend 30 seconds on it without figuring out what was up. Regardless, we should fix the race even if the reason it's triggering so easily legitimately is a bug. - Before patch: big error dialog (as in T11604). - After patch: smooth sailing. {F1804008} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11604 Differential Revision: https://secure.phabricator.com/D16514		2016-09-07 11:16:42 -07:00
..
__tests__	Minor formatting changes	2014-10-08 08:39:49 +11:00
DoorkeeperBridge.php	Recover from a race when importing external objects (like JIRA issues) for the first time	2016-09-07 11:16:42 -07:00
DoorkeeperBridgeAsana.php	Recover from a race when importing external objects (like JIRA issues) for the first time	2016-09-07 11:16:42 -07:00
DoorkeeperBridgedObjectInterface.php	Introduce "bridged" objects	2016-03-22 15:06:57 -07:00
DoorkeeperBridgeGitHub.php	Begin bridging GitHub objects through Doorkeeper	2016-03-09 09:29:21 -08:00
DoorkeeperBridgeGitHubIssue.php	Recover from a race when importing external objects (like JIRA issues) for the first time	2016-09-07 11:16:42 -07:00
DoorkeeperBridgeGitHubUser.php	Recover from a race when importing external objects (like JIRA issues) for the first time	2016-09-07 11:16:42 -07:00
DoorkeeperBridgeJIRA.php	Recover from a race when importing external objects (like JIRA issues) for the first time	2016-09-07 11:16:42 -07:00