1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 23:32:40 +01:00
phorge-phorge/src/infrastructure/diff
epriestley e9f4a84a89 Allow inline comments to be individually hidden
Summary:
Ref T7447. Implements per-viewer comment hiding. Once a comment is obsolete or uninteresting, you can hide it completely.

This is sticky per-user.

My hope is that this will strike a better balance between concerns than some of the other approaches (conservative porting, summarization, hide-all).

Specifically, this adds a new action here:

{F435621}

Clicking it completely collapses the comment into a small icon on the previous line, and saves the comment state as hidden for you:

{F435626}

You can click the icon to reveal all hidden comments below the line.

Test Plan:
  - Hid comments.
  - Showed comments.
  - Created, edited, deleted and submitted comments.
  - Used Diffusion comments (hiding is not implemented there yet, but I'd plan to bring it there eventually if it works out in Differential).

Reviewers: btrahan, chad

Reviewed By: btrahan

Subscribers: jparise, yelirekim, epriestley

Maniphest Tasks: T7447

Differential Revision: https://secure.phabricator.com/D13009
2015-05-27 10:28:38 -07:00
..
interface Allow inline comments to be individually hidden 2015-05-27 10:28:38 -07:00
query Publish draft "done" status when submitting comments/updates/actions/inlines 2015-03-24 05:26:12 -07:00
view Allow inline comments to be individually hidden 2015-05-27 10:28:38 -07:00
PhabricatorChangesetResponse.php Reduce code duplication for inline "Undo" 2015-03-09 10:26:53 -07:00
PhabricatorDifferenceEngine.php Differential - tighten up access of Differential data from other applications 2014-12-19 14:54:15 -08:00
PhabricatorInlineCommentController.php Allow inline comments to be individually hidden 2015-05-27 10:28:38 -07:00
PhabricatorInlineCommentPreviewController.php Touch up PHP/JS interactions for inline comments 2015-03-27 17:08:31 -07:00