1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 09:42:41 +01:00
phorge-phorge/src/applications/differential
epriestley b7c4f60e23 Only recognize "Fixes ..." in main revision content like the Summary or Test Plan
Summary:
Fixes T12642. Currently, writing "Fixes T..." in a comment gets picked up as a formal "fixes".

This is a bit confusing, and can also give you a "no effect" error if you "fixes ..." a task which is already "fixes"'d.

We could make the duplicate action a non-error, but just prevent the text from having an effect instead, which seems cleaner.

Test Plan:
  - Wrote "Fixes ..." in a summary, saw a "fixes" relationship established.
  - Wrote "Fixes ..." in a comment, got a "mention" instead.
  - `var_dump()`'d some stuff as a sanity check, looked reasonable.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12642

Differential Revision: https://secure.phabricator.com/D17805
2017-04-30 13:12:28 -07:00
..
__tests__ phtize all the things 2015-05-22 21:16:39 +10:00
application Remove counts from home navigation 2017-01-21 13:55:40 -08:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
command Define Differential email action in terms of EditEngine 2017-01-02 13:25:45 -08:00
conduit Remove old code for "Request Review" action from Differential 2017-03-28 11:50:40 -07:00
config Remove Differential "Title" custom field 2016-12-16 10:23:26 -08:00
constants Use ModularTransactions for accept/reject/resign in "differential.createcomment" 2017-03-20 16:43:43 -07:00
controller Remove PhabricatorFile::buildFromFileDataOrHash() 2017-04-04 16:18:00 -07:00
customfield Rename "getReviewerStatus()" to "getReviewers()" 2017-03-20 17:11:40 -07:00
doorkeeper Rename "needReviewerStatus()" into "needReviewers()" 2017-03-20 16:46:16 -07:00
edge Expose the commit/task/revision relationship edges to "edge.search" 2017-04-02 19:49:55 -07:00
editor Only recognize "Fixes ..." in main revision content like the Summary or Test Plan 2017-04-30 13:12:28 -07:00
engine Make yellow "draft" bubbles more generic 2017-01-13 09:02:19 -08:00
engineextension Provide a "Reviewers" attachment to "differential.revision.search" 2017-04-06 14:46:39 -07:00
exception Remove an unused class 2015-01-03 09:07:32 +11:00
field Rename "getReviewerStatus()" to "getReviewers()" 2017-03-20 17:11:40 -07:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
herald Fix a bad getStatus() call which is fataling during Herald rule evaluation 2017-03-22 10:03:38 -07:00
landing Make "Land Revision" button state consistent, prevent non-accepted lands 2015-10-27 18:51:59 +00:00
lipsum Rename "getReviewerStatus()" to "getReviewers()" 2017-03-20 17:11:40 -07:00
mail Rename "needReviewerStatus()" into "needReviewers()" 2017-03-20 16:46:16 -07:00
management Remove most of the legacy hunk code 2016-12-13 14:34:36 -08:00
parser Always parse the first line of a commit message as a title 2017-01-01 09:56:15 -08:00
phid Render revision and audit state icons in Maniphest 2017-01-12 13:23:13 -08:00
query Restrict Differential buckets to just ApplicationSearch views 2017-03-23 12:09:44 -07:00
relationships Convert all standard relationship-editing actions to modern Relationships code 2016-06-29 11:24:52 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
render Add a "Red/Green Colorblind" accessibility mode, make all web UIs and email respect it 2017-02-23 10:57:39 -08:00
search Rename "getReviewerStatus()" to "getReviewers()" 2017-03-20 17:11:40 -07:00
storage Replace Remarkup calls to PhabricatorHash::digest() with SHA256 2017-04-06 15:43:18 -07:00
typeahead Allow commits to be queried by repository using the tagged(...) typehaead function 2017-02-27 10:46:55 -08:00
view When a package or project has been accepted or rejected, show who did it ("Accepted (by dog)") 2017-04-20 13:07:08 -07:00
xaction When reviewing, always show "Accept" checkboxes for packages/projects, even if there's only one checkbox 2017-04-10 17:28:02 -07:00
DifferentialGetWorkingCopy.php Extend from Phobject 2015-06-15 18:02:27 +10:00