mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-28 17:52:43 +01:00
18249b097f
Summary: Ref T11114. This comments nearly working on EditEngine. Only significant issue I caught is that the "View" link doesn't render properly because it depends on JS which is tricky to hook up. I'll clean that up in a future diff. Test Plan: {F2279201} Reviewers: chad Reviewed By: chad Maniphest Tasks: T11114 Differential Revision: https://secure.phabricator.com/D17116
113 lines
3.2 KiB
PHP
113 lines
3.2 KiB
PHP
<?php
|
|
|
|
final class DifferentialTransactionComment
|
|
extends PhabricatorApplicationTransactionComment {
|
|
|
|
protected $revisionPHID;
|
|
protected $changesetID;
|
|
protected $isNewFile = 0;
|
|
protected $lineNumber = 0;
|
|
protected $lineLength = 0;
|
|
protected $fixedState;
|
|
protected $hasReplies = 0;
|
|
protected $replyToCommentPHID;
|
|
|
|
private $replyToComment = self::ATTACHABLE;
|
|
private $isHidden = self::ATTACHABLE;
|
|
private $changeset = self::ATTACHABLE;
|
|
|
|
public function getApplicationTransactionObject() {
|
|
return new DifferentialTransaction();
|
|
}
|
|
|
|
public function attachReplyToComment(
|
|
DifferentialTransactionComment $comment = null) {
|
|
$this->replyToComment = $comment;
|
|
return $this;
|
|
}
|
|
|
|
public function getReplyToComment() {
|
|
return $this->assertAttached($this->replyToComment);
|
|
}
|
|
|
|
protected function getConfiguration() {
|
|
$config = parent::getConfiguration();
|
|
$config[self::CONFIG_COLUMN_SCHEMA] = array(
|
|
'revisionPHID' => 'phid?',
|
|
'changesetID' => 'id?',
|
|
'isNewFile' => 'bool',
|
|
'lineNumber' => 'uint32',
|
|
'lineLength' => 'uint32',
|
|
'fixedState' => 'text12?',
|
|
'hasReplies' => 'bool',
|
|
'replyToCommentPHID' => 'phid?',
|
|
) + $config[self::CONFIG_COLUMN_SCHEMA];
|
|
$config[self::CONFIG_KEY_SCHEMA] = array(
|
|
'key_draft' => array(
|
|
'columns' => array('authorPHID', 'transactionPHID'),
|
|
),
|
|
'key_changeset' => array(
|
|
'columns' => array('changesetID'),
|
|
),
|
|
'key_revision' => array(
|
|
'columns' => array('revisionPHID'),
|
|
),
|
|
) + $config[self::CONFIG_KEY_SCHEMA];
|
|
return $config;
|
|
}
|
|
|
|
public function shouldUseMarkupCache($field) {
|
|
// Only cache submitted comments.
|
|
return ($this->getTransactionPHID() != null);
|
|
}
|
|
|
|
public static function sortAndGroupInlines(
|
|
array $inlines,
|
|
array $changesets) {
|
|
assert_instances_of($inlines, 'DifferentialTransaction');
|
|
assert_instances_of($changesets, 'DifferentialChangeset');
|
|
|
|
$changesets = mpull($changesets, null, 'getID');
|
|
$changesets = msort($changesets, 'getFilename');
|
|
|
|
// Group the changesets by file and reorder them by display order.
|
|
$inline_groups = array();
|
|
foreach ($inlines as $inline) {
|
|
$changeset_id = $inline->getComment()->getChangesetID();
|
|
$inline_groups[$changeset_id][] = $inline;
|
|
}
|
|
$inline_groups = array_select_keys($inline_groups, array_keys($changesets));
|
|
|
|
foreach ($inline_groups as $changeset_id => $group) {
|
|
// Sort the group of inlines by line number.
|
|
$items = array();
|
|
foreach ($group as $inline) {
|
|
$comment = $inline->getComment();
|
|
$num = $comment->getLineNumber();
|
|
$len = $comment->getLineLength();
|
|
$id = $comment->getID();
|
|
|
|
$items[] = array(
|
|
'inline' => $inline,
|
|
'sort' => sprintf('~%010d%010d%010d', $num, $len, $id),
|
|
);
|
|
}
|
|
|
|
$items = isort($items, 'sort');
|
|
$items = ipull($items, 'inline');
|
|
$inline_groups[$changeset_id] = $items;
|
|
}
|
|
|
|
return $inline_groups;
|
|
}
|
|
|
|
public function getIsHidden() {
|
|
return $this->assertAttached($this->isHidden);
|
|
}
|
|
|
|
public function attachIsHidden($hidden) {
|
|
$this->isHidden = $hidden;
|
|
return $this;
|
|
}
|
|
|
|
}
|