1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-11 08:06:13 +01:00
phorge-phorge/webroot/rsrc/js/application
epriestley 61216dc641 Fix a JS error when adding a project card directly to a subproject from a workboard
Summary:
Fixes T12152. When creating a subproject task directly from a parent project, we can get column information back about the subproject column, which isn't visible. Just ignore this rather than trying to draw a card into a column which does not exist.

This flow (see test plan) is a little unintuitive since the card never appears on the workboard, but this class of things is probably roughly somewhere in T4900.

Test Plan:
  - Create a parent project A.
  - Create subproject B.
  - On the workboard for A, select "Create Task..." from the dropdown.
  - Add tag "B" in the dialog that pops up.
  - Save the task.

Note that this flow creates a task tagged only with "B", since "A" and "B" are mutually exclusive tags.

Before patch: UI freezes (JX.Mask is never removed), JS error in console.
After patch: workflow completes. Note that card is (correctly) not visible: it's in an invisible subproject column.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12152

Differential Revision: https://secure.phabricator.com/D17242
2017-01-24 07:41:32 -08:00
..
aphlict Make documentation items in user menu update as you navigate in Quicksand 2017-01-17 15:55:52 -08:00
calendar Remove obsolete Calendar event date storage fields 2016-11-02 09:49:08 -07:00
config Fix custom field selector control in cases where the user doesn't edit anything 2015-05-25 05:34:23 -07:00
conpherence Wipe textarea immediately when submitting a new message in Conpherence 2016-12-01 10:08:11 -08:00
countdown Define JavaScript functions before they are used 2014-12-30 02:53:32 -08:00
daemon Execute Maniphest batch edits in the background with a web UI progress bar 2015-06-23 13:36:16 -07:00
dashboard Improve minor workboard drag behaviors 2016-02-02 06:42:41 -08:00
diff Make "View" links on Differential inline comment previews work again 2017-01-02 13:24:02 -08:00
differential Use EditEngine stacked comments in Diffusion 2017-01-11 14:46:48 -08:00
diffusion Improve "thread" rendering of unusually-shaped graphs 2016-07-01 11:15:24 -07:00
doorkeeper Various linter fixes. 2014-02-26 12:44:58 -08:00
drydock Show a more reasonable status element for pull requests 2015-10-21 11:28:26 -07:00
files Remove defunt project image choices 2016-01-19 08:50:59 -08:00
herald Fix an initialization issue in Herald rules in Chrome 2016-03-22 09:13:51 -07:00
maniphest Reorganize phui-object-item CSS, add drag ui 2016-12-14 11:53:17 -08:00
owners Change double quotes to single quotes in JavaScript. 2014-06-24 03:35:39 +10:00
passphrase Rename Passphrase credential control JS 2015-03-02 13:01:00 -08:00
pholio Allow Pholio mocks to be created and edited without drag-and-drop 2016-06-09 08:43:38 -07:00
phortune Remove support for Balanced payments 2015-03-13 15:47:37 -07:00
policy De-garbage the horrible garbage project section of the policy selection control 2016-02-05 09:50:06 -08:00
projects Fix a JS error when adding a project card directly to a subproject from a workboard 2017-01-24 07:41:32 -08:00
releeph Make scrolling happen relative to the main content frame 2015-01-25 08:42:40 -08:00
repository Symbol Search: Allow ctrl-click with no hover 2015-08-27 04:17:38 -07:00
search Allow profile menu items to be reordered 2016-01-13 11:45:57 -08:00
slowvote Replace the primary scrollbar with a fake one to prepare for a persistent chat column 2015-01-23 13:29:15 -08:00
transactions Make Differential inline events actually trigger comment preview refreshes 2017-01-19 12:32:49 -08:00
typeahead Implement viewer() and members(project) typeahead functions 2015-04-17 11:06:58 -07:00
uiexample Use window.confirm instead of confirm 2014-12-30 02:55:12 -08:00