epriestley eb73cb68ff Raise a setup warning when locked configuration has a configuration value stored in the database ... Summary: Ref T13249. See <https://discourse.phabricator-community.org/t/configuring-the-number-of-taskmaster-daemons/2394/>. Today, when a configuration value is "locked", we prevent //writes// to the database. However, we still perform reads. When you upgrade, we generally don't want a bunch of your configuration to change by surprise. Some day, I'd like to stop reading locked configuration from the database. This would defuse an escalation where an attacker finds a way to write to locked configuration despite safeguards, e.g. through SQL injection or policy bypass. Today, they could write to `cluster.mailers` or similar and substantially escalate access. A better behavior would be to ignore database values for `cluster.mailers` and other locked config, so that these impermissible writes have no effect. Doing this today would break a lot of installs, but we can warn them about it now and then make the change at a later date. Test Plan: - Forced a `phd.taskmasters` config value into the database. - Saw setup warning. - Used `bin/config delete --database phd.taskmasters` to clear the warning. - Reviewed documentation changes. - Reviewed `phd.taskmasters` documentation adjustment. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13249 Differential Revision: https://secure.phabricator.com/D20159		2019-02-13 12:27:48 -08:00
..
cluster	Cleanup some clustering rough edges	2018-12-20 11:19:19 -08:00
configuration	Raise a setup warning when locked configuration has a configuration value stored in the database	2019-02-13 12:27:48 -08:00
field	Document the "bin/auth revoke" tool	2018-01-23 14:02:18 -08:00
userguide	Make "bin/audit delete" synchronize commit audit status, and improve "bin/audit synchronize" documentation	2019-02-13 05:50:14 -08:00
feedback.diviner	Update support documentation for modern times	2015-10-19 13:29:24 -07:00
installation_guide.diviner	Issue setup guidance recommending MySQLi and MySQL Native Driver	2018-03-13 12:38:09 -07:00
introduction.diviner	Reorganize Diviner articles into user/ and tech/	2013-08-28 09:57:00 -07:00
reporting_security.diviner	Update support documentation for modern times	2015-10-19 13:29:24 -07:00
support.diviner	Update the "Support Resources" documentation for pacts instead of consulting	2018-03-14 08:27:11 -07:00
upgrading.diviner	Write 500 words on how to restart webservers	2015-12-02 09:16:10 -08:00