1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 08:12:40 +01:00
phorge-phorge/src/applications/differential/controller
epriestley f010730e49 Migrate all Differential inline comments to ApplicationTransactions
Summary:
Ref T2222. This implements step (1) described there, which is moving over all the inline comments.

The old and new tables are simliar. The only real trick here is that `transactionPHID` and `legacyCommentID` mean roughly the same thing (`null` if the inline is a draft, non-null if it has been submitted) but we don't have real `transactionPHID`s yet. We just make some up -- we'll backfill them later.

Two risks here:

  - I need to take a second look at the keys on this table. I think we need to tweak them a bit, and it will be less disruptive to do that before this migration than after.
  - This will take a while for Facebook, and other large installs with tens of thousands of revisions. I'll communicate this.

I'm otherwise pretty satisfied with this, seems to work well and is pretty low risk / non-disruptive.

Test Plan:
  - Before migrating, then after migrating:
    - Made a bunch of inlines (drafts, submitted).
    - Edited and deleted inlines.
    - Verified inlines showed up in preview.
    - Verified that inlines aren't indexed when they're drafts (`bin/search index D935`).
    - Verified that inlines ARE indexed when they're not drafts.
    - Verified that drafts inlines make revisions appear as "with draft" in the revision list.
  - Made left, right, and draft inlines.
  - Migrated (`bin/storage upgrade`).
  - Verified that my inlines from before the migration still showed up.
  - (Repeated all the stuff above.)
  - Manually inspected the inline comment table.

Reviewers: btrahan

Reviewed By: btrahan

CC: FacebookPOC, aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D7139
2013-10-19 05:03:25 -07:00
..
DifferentialChangesetViewController.php Make most file reads policy-aware 2013-09-30 09:38:13 -07:00
DifferentialCommentPreviewController.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialCommentSaveController.php Make most Differential reads policy-aware 2013-09-26 12:37:19 -07:00
DifferentialController.php Use ApplicationSearch in Differential 2013-07-03 06:11:07 -07:00
DifferentialDiffCreateController.php Move PHUIFormBoxView to PHUIObjectBoxView 2013-09-25 11:23:29 -07:00
DifferentialDiffViewController.php PHUIPropertyListView 2013-10-11 07:53:56 -07:00
DifferentialInlineCommentEditController.php Migrate all Differential inline comments to ApplicationTransactions 2013-10-19 05:03:25 -07:00
DifferentialInlineCommentPreviewController.php Abstract access to DifferentialInlineComment behind a Query 2013-06-21 12:54:56 -07:00
DifferentialRevisionDetailRenderer.php Pass user to DifferentialRevisionDetailRenderer 2013-03-04 11:32:02 -08:00
DifferentialRevisionEditController.php Add a "default view" policy to Differential 2013-10-09 13:58:00 -07:00
DifferentialRevisionListController.php Make Differential views capability-sensitive 2013-09-26 18:45:04 -07:00
DifferentialRevisionViewController.php Delete unintentional phlog() 2013-10-16 13:59:23 -07:00
DifferentialSubscribeController.php Use DifferentialRevisionQuery in differential controllers 2013-07-15 16:01:31 -07:00