revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 02:12:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/webroot/rsrc/js/core
History
epriestley f02aed10e7 Fix three issues with scrolling while dragging items (e.g., on workboards) 
Summary:
Fixes T5979. There are three issues here:

  - We cache document positions when you pick an item up, but don't recalculate them after you scroll, so they get out of date. Dirty the cache when the user scrolls.
  - When we rebuild the cache during a drag (previously, this never happened), the position of the object you're dragging is computed wrong (since it has been moved to be under the cursor). Adjust the effective position of the object you've picked up to put it back in the right place in the list.
  - When you fiddle around at the bottom of a column you can get jumpy redraws as the height adjusts. Put `min-height` on the container during a drag to prevent this.

Test Plan: In Safari, Chrome and Firefox, dragged items around on columns before and after scrolling the workboard panel.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5979

Differential Revision: https://secure.phabricator.com/D10455
2014-09-09 14:20:27 -07:00
..
behavior-active-nav.js Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
behavior-audio-source.js Implement macros as audio sources 2013-09-27 16:02:02 -07:00
behavior-autofocus.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-choose-control.js Move project icon editing into "Edit Details" 2014-06-26 09:41:07 -07:00
behavior-crop.js Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
behavior-dark-console.js Change double quotes to single quotes in JavaScript. 2014-06-24 03:35:39 +10:00
behavior-device.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-drag-and-drop-textarea.js Change double quotes to single quotes in JavaScript. 2014-06-24 03:35:39 +10:00
behavior-error-log.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-fancy-datepicker.js Modernize DatePicker 2014-08-16 14:55:22 -07:00
behavior-file-tree.js Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
behavior-form.js Apply some linter auto-fixes 2014-08-02 19:03:02 +10:00
behavior-gesture.js Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
behavior-global-drag-and-drop.js Give files uploaded to objects a very restrictive view policy 2014-08-02 14:46:13 -07:00
behavior-high-security-warning.js Add "High Security" mode to support multi-factor auth 2014-04-27 17:31:11 -07:00
behavior-history-install.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-hovercard.js Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
behavior-keyboard-pager.js Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
behavior-keyboard-shortcuts.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-konami.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-lightbox-attachments.js Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
behavior-line-linker.js Fix a JS issue in Paste 2014-05-30 10:07:33 -07:00
behavior-more.js Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
behavior-object-selector.js Change double quotes to single quotes in JavaScript. 2014-06-24 03:35:39 +10:00
behavior-oncopy.js Change double quotes to single quotes in JavaScript. 2014-06-24 03:35:39 +10:00
behavior-phabricator-nav.js Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
behavior-phabricator-remarkup-assist.js Various minor JSHint fixes. 2014-07-01 06:00:12 +10:00
behavior-refresh-csrf.js Provide a global router for Ajax requests 2014-05-05 10:57:42 -07:00
behavior-remarkup-preview.js Partially generalize Remarkup previews and add support to Differential 2013-08-05 10:46:39 -07:00
behavior-reorder-applications.js Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
behavior-reveal-content.js Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
behavior-search-typeahead.js Share more code between tokenizers and global typeahead 2014-07-17 15:52:58 -07:00
behavior-select-on-click.js Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
behavior-toggle-class.js Remove @group annotations 2014-07-10 08:12:48 +10:00
behavior-tokenizer.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-tooltip.js Move project icon editing into "Edit Details" 2014-06-26 09:41:07 -07:00
behavior-watch-anchor.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
behavior-workflow.js Provide a global router for Ajax requests 2014-05-05 10:57:42 -07:00
Busy.js Fix full width form layouts 2013-07-03 20:24:28 -07:00
DragAndDropFileUpload.js Remarkup - call pasted files "pasted_file" rather than "undefined" 2014-08-20 16:21:50 -07:00
DraggableList.js Fix three issues with scrolling while dragging items (e.g., on workboards) 2014-09-09 14:20:27 -07:00
FileUpload.js Various linter fixes. 2014-02-26 12:44:58 -08:00
Hovercard.js Change double quotes to single quotes in JavaScript. 2014-06-24 03:35:39 +10:00
KeyboardShortcut.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
KeyboardShortcutManager.js Move js/application/core/ one level up 2013-04-23 10:56:46 -07:00
MultirowRowManager.js Change double quotes to single quotes in JavaScript. 2014-06-24 03:35:39 +10:00
Notification.js Various linter fixes. 2014-02-26 12:44:58 -08:00
phtize.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
Prefab.js Fix rendering of project slugs in tokenizer UI 2014-07-21 06:44:27 -07:00
ShapedRequest.js Provide a global router for Ajax requests 2014-05-05 10:57:42 -07:00
TextAreaUtils.js Add a Javascript method to find the pixel position of a range in a textarea 2014-08-18 13:15:40 -07:00
ToolTip.js Fixing tooltips not appearing in fullscreen editor 2014-04-12 05:59:36 -07:00