revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 08:12:40 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/differential/controller
History
epriestley f12dbe36d6 Raise a better error when a file upload fails in Differential 
Summary:
Ref T2296. If a file upload fails (e.g., too large), we read the textarea from the "Create New Diff" interface. This means we show the user an error like "empty diff" when we should show them an error like "file upload failed, patch is too large". This is part of the issue in T2296, which features a 2.5MB diff.

Instead, check if a file was specified, so we'll raise a better error.

Test Plan: Tried to upload a large patch, got a "file is too large" error instead of an empty-diff-related error.

Reviewers: btrahan, vrana, codeblock

Reviewed By: codeblock

CC: aran

Maniphest Tasks: T2296

Differential Revision: https://secure.phabricator.com/D4369
2013-01-09 08:14:17 -08:00
..
DifferentialChangesetViewController.php make differential use fluid width for code layout 2012-12-06 11:33:04 -08:00
DifferentialCommentPreviewController.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialCommentSaveController.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialController.php Add crumbs to Differential 2012-12-07 13:37:45 -08:00
DifferentialDiffCreateController.php Raise a better error when a file upload fails in Differential 2013-01-09 08:14:17 -08:00
DifferentialDiffViewController.php Use "Diff <id>" instead of "D<id>" in changeset view 2012-12-20 18:28:34 -08:00
DifferentialInlineCommentEditController.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialInlineCommentPreviewController.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialRevisionDetailRenderer.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialRevisionEditController.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialRevisionListController.php Add crumbs to Differential 2012-12-07 13:37:45 -08:00
DifferentialRevisionStatsController.php Delete license headers from files 2012-11-05 11:16:51 -08:00
DifferentialRevisionViewController.php Use "Diff <id>" instead of "D<id>" in changeset view 2012-12-20 18:28:34 -08:00
DifferentialSubscribeController.php Delete license headers from files 2012-11-05 11:16:51 -08:00