revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-28 00:10:57 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
Fabian Stelzer f33e2de092 make repo callsigns optional 
Summary:
Ref T4245 Make repo callsigns optional
This is far from done and still very ugly. I'm just submitting it to check if i'm solving this in the right places.
Right now there's three places with duplicate code and building the identifierMap in the CommitQuery is very ugly.
If we only want to support this in the user frontend then i could hack it into the Markup rule itself and not touch the CommitQuery. Even uglier but more limited in scope...

Generally this approach will need a lot of "check this first and then try the other" in a few places.
I could move the Repository queries into a specialised PhabricatorRepositoryQuery method (withCallsignOrID) but i'm not sure about that.

Test Plan:
 - phid.lookup works with R1 and rTEST (which is the same repo)
 - R1 and rTEST euqally work in remarkup (tested in comments).
 - Reviewed the following syntax also all works:
rTEST
rTESTd773137a7cb9
rTEST:d773137a7cb9
R1
R1:d773137a7cb9
d773137a7cb9
{rTEST}
{rTESTd773137a7cb9}
{rTEST:d773137a7cb9}
{R1}
{R1:d773137a7cb9}
{d773137a7cb9}

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T4245

Differential Revision: https://secure.phabricator.com/D11050
2015-01-01 08:07:26 -08:00
..
almanac Almanac: forced interface PHIDs, prefix/suffix device query, DestructibleInterface 2014-12-22 12:50:44 -08:00
aphlict/management Try nodejs before node when starting notification server 2014-06-07 13:56:23 -07:00
arcanist/conduit Rename Conduit classes 2014-07-25 10:54:15 +10:00
audit Home - limit "status" queries to 100 and show 99+ if we hit that 2014-12-12 12:02:25 -08:00
auth Fixing typo unautorized -> unauthorized. 2014-12-22 12:57:49 -08:00
base Home - limit "status" queries to 100 and show 99+ if we hit that 2014-12-12 12:02:25 -08:00
cache Automatically build all Lisk schemata 2014-10-02 09:51:20 -07:00
calendar Decouple some aspects of request routing and construction 2014-10-17 05:01:40 -07:00
celerity Remove docs sprite, replace with FontAwesome 2014-12-20 20:59:24 -08:00
chatlog Minor formatting changes 2014-10-08 08:39:49 +11:00
conduit Generate and use "cluster" Conduit API tokens 2014-12-15 11:15:14 -08:00
config Settings History 2015-01-01 06:52:13 -08:00
conpherence Remove docs sprite, replace with FontAwesome 2014-12-20 20:59:24 -08:00
console Move DarkConsole to an application 2014-10-13 11:17:09 -07:00
countdown Decouple some aspects of request routing and construction 2014-10-17 05:01:40 -07:00
daemon Allow archived tasks to be queried by object PHID and order by id 2014-12-30 15:54:56 -08:00
dashboard Link search query to Dashboard header title 2014-12-18 08:40:50 -08:00
differential Migrate Differential revision edges to use modern EdgeType subclasses 2015-01-01 15:07:03 +11:00
diffusion make repo callsigns optional 2015-01-01 08:07:26 -08:00
diviner Use new FutureIterator instead of Futures 2014-12-30 23:13:38 +11:00
doorkeeper Use new FutureIterator instead of Futures 2014-12-30 23:13:38 +11:00
draft/storage Automatically build all Lisk schemata 2014-10-02 09:51:20 -07:00
drydock Transactions - adding willRenderTimeline to handle tricky cases 2014-12-04 13:58:52 -08:00
fact Minor formatting changes 2014-10-08 08:39:49 +11:00
feed Lock feed.public and feed.http-hooks config options 2014-12-29 08:04:47 -08:00
files show the current size limit when a file upload fails 2014-12-23 05:17:16 -08:00
flag Home - limit "status" queries to 100 and show 99+ if we hit that 2014-12-12 12:02:25 -08:00
fund Transactions - adding willRenderTimeline to handle tricky cases 2014-12-04 13:58:52 -08:00
harbormaster Use new FutureIterator instead of Futures 2014-12-30 23:13:38 +11:00
help Update Phabricator header to use FontAwesome 2014-12-04 13:01:23 -08:00
herald Differential - tighten up access of Differential data from other applications 2014-12-19 14:54:15 -08:00
home Maniphest - introduce needProjectPHIDs 2014-12-18 13:53:45 -08:00
legalpad Modernize Legalpad edge types 2015-01-01 11:15:34 +11:00
lipsum Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
macro Transactions - adding willRenderTimeline to handle tricky cases 2014-12-04 13:58:52 -08:00
mailinglists Decouple some aspects of request routing and construction 2014-10-17 05:01:40 -07:00
maniphest Do not CC users without permissions to view an object 2015-01-01 08:05:52 -08:00
meta Have app tooltips align east with more width 2014-12-18 14:03:13 -08:00
metamta Daemons - add "objectPHID" to task tables. 2014-12-23 16:30:05 -08:00
notification Decouple some aspects of request routing and construction 2014-10-17 05:01:40 -07:00
nuance Transactions - adding willRenderTimeline to handle tricky cases 2014-12-04 13:58:52 -08:00
oauthserver Decouple some aspects of request routing and construction 2014-10-17 05:01:40 -07:00
owners Owners - sort repositories alphabetically in path chooser 2014-12-30 14:28:26 -08:00
passphrase Title/Description quering for Passphrase credential 2014-12-09 16:23:09 -08:00
paste Paste: Add edit policy 2014-12-31 08:24:57 -08:00
people Do not CC users without permissions to view an object 2015-01-01 08:05:52 -08:00
phame Prevent Phame blogs from using invalid skins 2014-12-15 10:41:49 -08:00
phid Don't skip policy checks on ObjectQuery if special capabilities are required 2014-12-17 17:04:12 -08:00
phlux Transactions - adding willRenderTimeline to handle tricky cases 2014-12-04 13:58:52 -08:00
pholio Pholio - fix show older transactions for if there are inline comments 2014-12-17 09:42:37 -08:00
phortune Transactions - adding willRenderTimeline to handle tricky cases 2014-12-04 13:58:52 -08:00
phpast Minor formatting changes 2014-10-08 08:39:49 +11:00
phragment Minor formatting changes 2014-10-08 08:39:49 +11:00
phrequent Home - limit "status" queries to 100 and show 99+ if we hit that 2014-12-12 12:02:25 -08:00
phriction Phriction - validateTransactions that need parent ancestry to complete successfully 2014-12-12 11:35:43 -08:00
policy Linkify Registration Email 2014-11-07 14:16:30 -08:00
ponder Modernize Ponder edge types 2015-01-01 11:20:22 +11:00
project Improve puncutation usage 2015-01-01 15:40:04 +11:00
releeph Migrate Differential revision edges to use modern EdgeType subclasses 2015-01-01 15:07:03 +11:00
remarkup/conduit Rename Conduit classes 2014-07-25 10:54:15 +10:00
repository make repo callsigns optional 2015-01-01 08:07:26 -08:00
search Migrate Differential revision edges to use modern EdgeType subclasses 2015-01-01 15:07:03 +11:00
settings Make settings a wrench, not a cog 2014-12-04 17:36:15 -08:00
slowvote Transactions - adding willRenderTimeline to handle tricky cases 2014-12-04 13:58:52 -08:00
subscriptions Maniphest - use subscribers framework properly 2014-12-10 16:27:30 -08:00
support/application Implement the getName method in PhabricatorApplication subclasses 2014-07-23 23:52:50 +10:00
system Automatically build all Lisk schemata 2014-10-02 09:51:20 -07:00
tokens Minor formatting changes 2014-10-08 08:39:49 +11:00
transactions Do not CC users without permissions to view an object 2015-01-01 08:05:52 -08:00
typeahead Projects - tokenize projects more aggressively with respect to '-' 2014-08-14 12:28:11 -07:00
uiexample Remove payments sprite 2014-12-20 09:44:53 -08:00
xhprof Automatically build all Lisk schemata 2014-10-02 09:51:20 -07:00