1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 00:02:41 +01:00
phorge-phorge/src/applications/harbormaster
epriestley f48a833704 Fix an issue with incorrect authorization handling in Working Copy build steps
Summary:
Fixes T9669. Two issues:

  - We were using `repositoryPHIDs` instead of `blueprintPHIDs` for the list of allowed blueprints. Use the correct value.
  - We weren't enforcing `allowedBlueprintPHIDs` fully correctly. We //did// require an authorization, so the net effect was correct in nearly all cases, but we could have selected from too large a pool in the case where the application itself was doing the authorization (e.g., from the command line).

Test Plan: Ran a build through Drydock/Harbormaster locally.

Reviewers: chad, tycho.tatitscheff

Reviewed By: chad, tycho.tatitscheff

Subscribers: tycho.tatitscheff

Maniphest Tasks: T9669

Differential Revision: https://secure.phabricator.com/D14368
2015-10-30 16:02:35 +00:00
..
__tests__ Add "Autoplans" to Harbormaster 2015-06-21 09:04:21 -07:00
application Give Harbormaster build steps a "View" page 2015-10-26 12:38:32 -07:00
artifact In Harbormaster, make sure artifacts are destroyed even if a build is aborted 2015-10-05 05:58:53 -07:00
autoplan Give "Arcanist Client Results" a more clear name 2015-09-09 19:18:08 -07:00
capability Give Harbormaster Build Plans real policies 2015-10-26 12:38:21 -07:00
conduit Add harbormaster.createartifact 2015-08-15 07:28:56 -07:00
config Add getGroup to ConfigOptions 2015-02-09 13:10:56 -08:00
controller Give Harbormaster build steps a "View" page 2015-10-26 12:38:32 -07:00
customfield Use Drydock authorizations when acquiring leases 2015-10-12 17:02:35 -07:00
editor Give Harbormaster Build Plans real policies 2015-10-26 12:38:21 -07:00
engine Allow builds to have parameters 2015-10-02 06:32:08 -07:00
event Show external build links in applications 2015-08-15 07:29:26 -07:00
exception Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
future Allow Harbormaster to run commands on Drydock working copies 2015-09-25 10:43:32 -07:00
herald Allow builds to have parameters 2015-10-02 06:32:08 -07:00
interface Move build variables into HarbormasterBuildableInterface 2014-06-20 12:58:23 +10:00
management Remove Drydock host resource limits and give working copies simple limits 2015-10-26 12:39:47 -07:00
phid Correct the handle URI for build steps 2015-10-30 15:54:10 +00:00
query Show external build links in applications 2015-08-15 07:29:26 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
step Fix an issue with incorrect authorization handling in Working Copy build steps 2015-10-30 16:02:35 +00:00
stepgroup Put Drydock build steps into their own group in Harbormaster 2015-10-05 15:59:35 -07:00
storage Give Harbormaster Build Plans real policies 2015-10-26 12:38:21 -07:00
typeahead Give typeahead browse dialogs sensible titles 2015-04-20 10:06:23 -07:00
view Remove leftover code for "postponed" lint and unit status 2015-08-29 22:19:28 +10:00
worker Allow Harbormaster build plans to request additional working copies 2015-09-28 17:57:41 -07:00