1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/applications/harbormaster/step
epriestley f48a833704 Fix an issue with incorrect authorization handling in Working Copy build steps
Summary:
Fixes T9669. Two issues:

  - We were using `repositoryPHIDs` instead of `blueprintPHIDs` for the list of allowed blueprints. Use the correct value.
  - We weren't enforcing `allowedBlueprintPHIDs` fully correctly. We //did// require an authorization, so the net effect was correct in nearly all cases, but we could have selected from too large a pool in the case where the application itself was doing the authorization (e.g., from the command line).

Test Plan: Ran a build through Drydock/Harbormaster locally.

Reviewers: chad, tycho.tatitscheff

Reviewed By: chad, tycho.tatitscheff

Subscribers: tycho.tatitscheff

Maniphest Tasks: T9669

Differential Revision: https://secure.phabricator.com/D14368
2015-10-30 16:02:35 +00:00
..
__tests__ Add a bunch of tests for subclass implementations 2015-06-15 18:13:27 +10:00
HarbormasterArcLintBuildStepImplementation.php Lump Harbormaster build steps into groups 2015-08-06 04:19:42 -07:00
HarbormasterArcUnitBuildStepImplementation.php Lump Harbormaster build steps into groups 2015-08-06 04:19:42 -07:00
HarbormasterBuildStepImplementation.php Allow builds to have parameters 2015-10-02 06:32:08 -07:00
HarbormasterCommandBuildStepImplementation.php Probably fix bad loadArtifactLease() call 2015-08-18 10:46:41 -07:00
HarbormasterDrydockCommandBuildStepImplementation.php Put Drydock build steps into their own group in Harbormaster 2015-10-05 15:59:35 -07:00
HarbormasterHTTPRequestBuildStepImplementation.php Acccept any HTTP 2xx status as success in Harbormaster 2015-10-02 09:17:51 -07:00
HarbormasterLeaseHostBuildStepImplementation.php Associate Harbormaster build target with leases 2015-08-24 17:20:59 +10:00
HarbormasterLeaseWorkingCopyBuildStepImplementation.php Fix an issue with incorrect authorization handling in Working Copy build steps 2015-10-30 16:02:35 +00:00
HarbormasterPublishFragmentBuildStepImplementation.php Add harbormaster.createartifact 2015-08-15 07:28:56 -07:00
HarbormasterSleepBuildStepImplementation.php Lump Harbormaster build steps into groups 2015-08-06 04:19:42 -07:00
HarbormasterThrowExceptionBuildStep.php Lump Harbormaster build steps into groups 2015-08-06 04:19:42 -07:00
HarbormasterUploadArtifactBuildStepImplementation.php Remove call to loadDrydockLease 2015-08-18 17:52:55 -07:00
HarbormasterWaitForPreviousBuildStepImplementation.php Lump Harbormaster build steps into groups 2015-08-06 04:19:42 -07:00